"working changes" detection doesn't work w/ submodules about dapptools HOT 3 CLOSED

Comment by dbrock
Thursday Feb 16, 2017 at 19:51 GMT

Wait, can you explain what you did again?

I know submodules can be tricky so I agree we should try to be as helpful as possible

from dapptools.

Comment by nmushegian
Thursday Feb 16, 2017 at 19:59 GMT

Untracked changes within submodules appear in the "changes not staged for commit" area as dirname (untracked content), which you use to detect if we should stop actions. But this is a special submodule state that really should be treated like a clean stage.

for example:

dapp install ds-auth
touch file.txt
dapp install ds-note   # all good, file.txt is not tracked yet so dapp doesn't block me
touch ds-auth/file.txt
git add file.txt && git commit -am "clear working state in parent (added file.txt)"
dapp install ds-token   # blocked by ds-auth/file.txt - also not tracked, and it's even less relevant

from dapptools.

Comment by dbrock
Monday Dec 11, 2017 at 09:15 GMT

Ah I see, yeah I guess what you're saying makes sense!

from dapptools.