Dapper.Contrib does not pass Turkey Test about dapper.contrib HOT 5 OPEN

If you changed it to compare to "ID" instead of "id" does it work for you? Apparently ToUpper works better for Turkey, don't know if it fails for other cultures though.

from dapper.contrib.

@rhubley

ToUpper can make it "İD", so it will fail again :)

I think the best way is adding culture to string.equal operation. For now, we wrote a custom convert method to change ıd to id, İD to ID etc.

from dapper.contrib.

@yusufozturk
Could you share your ext. method ? or what does it exactly do for it ?

from dapper.contrib.

Setting a culture is tricky, you would need your code and Database to share the same culture which might not always be the case.

from dapper.contrib.

We should probably address this by using whatever locale is used in the model object, by changing the hardcoded "id" to grabbing the variable name from the object itself. This would mean that if they define the model in turkish(is that the name of the language?) that should give us the correct variable to query against. (grabbed via the [Key] attribute, of course)

Edit: NVM, this is not needed. This is an internal thing. We are using the wrong method for comparing them, I think.
see reference: https://msdn.microsoft.com/en-us/library/system.stringcomparer.currentcultureignorecase(v=vs.110).aspx

from dapper.contrib.