Comments (16)
from isoclassify.
Hey Case,
I'm glad you figured out a temporary hack to get it working on your computer!
I was mostly pointing this out so it can hopefully be fixed in newer updates/versions i.e. so you don't have to have your computer point to an older version. The setup function defines the console point, so I actually didn't even have the ISOCLASSIFY
environment defined in the bashrc (for me, zsh) file (since this really should be avoided anyway). In the meantime, I'll use the older version you linked so I can at least get some stellar parameters :)
Ashley
from isoclassify.
Thanks for the update @ashleychontos and @SpaceyCaseyLynn! I can look into potential fixes for this. If either of you want a go at fixing instead feel free and let me know, I'm happy to help where possible!
from isoclassify.
To expand on what I mean by duplicated items, first shown is a fresh copy of Dan's git repo:
![Screenshot 2023-11-09 at 6 08 14 PM](https://private-user-images.githubusercontent.com/13820495/281910034-87eba1e3-826b-4849-bcb8-53b95b13fec1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU2ODQyODAsIm5iZiI6MTcwNTY4Mzk4MCwicGF0aCI6Ii8xMzgyMDQ5NS8yODE5MTAwMzQtODdlYmExZTMtODI2Yi00ODQ5LWJjYjgtNTNiOTViMTNmZWMxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTE5VDE3MDYyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYxNGU0MTMyMzUxNTNiYWJiM2I0NGE2NTU2YzE4MjI1ZjY4OTA0NmZhZmM1NDEyODQ5Y2JhNTZiNTE0ODM0ZWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9FInPYwuIv2CXN9QP0hoMQYM8EFHylikvvnopaTE6zg)
Then after cd'ing into the isoclassify/
directory and running pip install .
, the current setup.py
file creates duplicates of all files in isoclassify/isoclassify
in the main isoclassify/
repo:
![Screenshot 2023-11-09 at 6 09 13 PM](https://private-user-images.githubusercontent.com/13820495/281910075-c98b8f7e-9def-4b4b-88c7-602b18683c3f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU2ODQyODAsIm5iZiI6MTcwNTY4Mzk4MCwicGF0aCI6Ii8xMzgyMDQ5NS8yODE5MTAwNzUtYzk4YjhmN2UtOWRlZi00YjRiLTg4YzctNjAyYjE4NjgzYzNmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTE5VDE3MDYyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkzNTk2ZTViOGNhYzcyODgwZjFhZmI3YjFhMjkxMTI4OWYzOTZiZjU2NDI3NWQxNTJiOWU3ODRlYzllMjU0MzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1nREliydKbqz6p8UK1DiZ3JIEE21owSIfvIZVgt2V-g)
In order to diagnose the main issue, perhaps it would be helpful to use different names for the main and subdirectories. I think the copying of all files at both levels could easily make this a very difficult problem to pin down.
from isoclassify.
I still cannot reproduce the error, but have an idea of why you both might be seeing it.
Did you clone the isoclassify repo directly into your .../python3.10/site-packages
directory? If so then I think that is where the issue comes from. The site-packages
directory is where Python puts packages when you pip
install them. If you put the package source code in site-packages, then that would explain the duplication issue. Since the package is already there, pip
just puts a copy of it there.
Try cloning the repo somewhere else (e.g. directly into your home directory). Then go through the install instructions.
If you want to clone my fix for the version number bug then clone my working branch git clone -b version https://github.com/alexlyttle/isoclassify.git
.
If I'm wrong or that doesn't work let me know and I'll keep digging!
If we add the package to PyPI then you can just pip install it without cloning the repository and that will stop this from happening.
P.S. if this fixes the issue I'll suggest updating the REAME to be clearer
from isoclassify.
Thanks all, this has now been implemented and the code is pip-installable.
from isoclassify.
@SpaceyCaseyLynn I think the issue should be fixed now, but I couldn't reproduce it exactly on my system.
Could you see if my changes have fixed the issue? To do so, run the following code in your terminal,
git clone -b version https://github.com/alexlyttle/isoclassify.git
cd isoclassify
pip install .
This will clone my 'fixed' version of isoclassify
and attempt to pip install it. Please let me know if it works or not.
You may continue following installation instructions with my fixed version of isoclassify
until Pull Request #40 is merged with the main version. It should work the same.
from isoclassify.
from isoclassify.
Whoops, looks like the error message didn't attach over email! Here it is
from isoclassify.
Thanks for letting me know @SpaceyCaseyLynn. Just got back from vacation so only just saw this. I will try and reproduce this soon and get back to you.
from isoclassify.
Unfortunately, I cannot reproduce your error message. Could you attach the output of pip list
and conda list
?
In the meantime, you could try pip uninstall isoclassify
and then go through the installation instructions again. The error message implies the isoclassify
package has not been installed, which is a bit odd.
from isoclassify.
Something similar just happened to me after successfully installing the software with my new(er) python version (3.10):
![Screenshot 2023-11-09 at 4 51 58 PM](https://private-user-images.githubusercontent.com/13820495/281888358-d9b462f2-652c-46db-afa5-2c8149d4200c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU2ODQyODAsIm5iZiI6MTcwNTY4Mzk4MCwicGF0aCI6Ii8xMzgyMDQ5NS8yODE4ODgzNTgtZDliNDYyZjItNjUyYy00NmRiLWFmYTUtMmM4MTQ5ZDQyMDBjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTE5VDE3MDYyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM1MDRkMmZlNDYwNDIzOTQ4NDU2YWE4NmYzMzcwZTlkZGJkMmQyNDQ4YzYzZTcxZmVjY2VhNjI5NGY1ZWNhNzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.I-yhELWhsNEjvfslp-wsMxe6zqUprdXg0VliRbpeIo0)
from isoclassify.
I tried another fresh install and I think the issue may be with how the setup function is defined because it installs copies of the isoclassify.direct and isoclassify.grid folders in the source directory (see attached) **edit: the entire isoclassify/ directory is copied in the source directory. Presumably this is confusing the software with where to look for specific packages (you can see that the distribution info is also saving within the source directory too):
![Screenshot 2023-11-09 at 5 12 58 PM](https://private-user-images.githubusercontent.com/13820495/281896000-abce23b4-cc5c-47fd-9360-bd71082d07fd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU2ODQyODAsIm5iZiI6MTcwNTY4Mzk4MCwicGF0aCI6Ii8xMzgyMDQ5NS8yODE4OTYwMDAtYWJjZTIzYjQtY2M1Yy00N2ZkLTkzNjAtYmQ3MTA4MmQwN2ZkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTE5VDE3MDYyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA2Mjc2NDQwMTliOTMwMWM3YzZjNDA3Y2EzYjY5YjdkMGQ2MGQyMWI3YmJhMGM2ODRiMGI5ZGJmODFhNTg5NzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ZgPTrzAYG9QDtBnPHTsDNZxq2Yy6W6mu-D8eIc9n72M)
from isoclassify.
from isoclassify.
Ok so I did what you suggested and it works now, but there are still two copies on my computer. I deleted the local copy and it appears that the command-line help is still working -> which bring me to my final question: It seems like you've already put in the actual work to easily make this possible, so why not make it pip-installable to prevent people from having to make the two copies on their computer?
Either way, thanks for helping me out. I agree having something about not running it from python site-packages would be helpful.... as someone who used to be very bad at keeping python packages in one place (and now religiously does it). I thought I was doing the right thing by cloning it there only to make things worse!
from isoclassify.
It seems like you've already put in the actual work to easily make this possible, so why not make it pip-installable to prevent people from having to make the two copies on their computer?
Absolutely, that would be great! I am not the repository maintainer so would need to run this by @danxhuber. This involves uploading the package to PyPI. Ideally, it would be uploaded after Dan or another maintainer merges PR #40 (the version number fix), as I don't have permission to merge it.
If you just ran pip install .
and did not use the -e
flag, then you can just delete your clone of the repository and the package will still work. Then you won't have multiple copies on your computer.
Either way, thanks for helping me out. I agree having something about not running it from python site-packages would be helpful....
You're welcome! Yeah, it can get messy very quickly, especially if using virtual environment or conda
. But it's not wrong to put code in site-packages
when it doesn't need to be build with pip install
. Really, our README needs to be clearer!
from isoclassify.
Related Issues (16)
- add script to combine CLI output? HOT 2
- Non-deterministic dustmap sampling HOT 3
- reddening code HOT 3
- Implement diffusion grid HOT 1
- Asteroseismic Dnu corrections not working in direct mode
- Timeout when doing many bayestar queries with green18 dustmap HOT 3
- Using Gaia Bp-Rp to derive temperature in grid mode HOT 1
- Inconsistent behavior? Sometimes no mass/density calculated. HOT 3
- bcgrid Dropbox Link Returns 404 HOT 1
- The path for bprp-solar-mist.txt is broken HOT 1
- Mac OS - OSError: Unable to open file (unable to open file) HOT 1
- Parameter d51mag does not exist in mesa.h5 file HOT 1
- Non-string id_starname HOT 1
- Squeeze keyword preventing the full output.csv file from generating HOT 2
- Make classify_direct work with other filters HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from isoclassify.