Line numbers flashing when opening new directories about vsnetrw HOT 4 CLOSED

I can confirm it works now. Thanks for fixing this so quickly!

from vsnetrw.

Hey @lwieckowski 👋! Taking a look at this now.

I have line numbers disabled globally across vscode, so I'm afraid I wouldn't ever have caught this in development.

I can't explicitly remember doing anything specific to turn line numbers off as part of the extension, but it seems like I did add that to the package specific configuration here.

Given that they appear then disappear, I wonder if vscode is reloading the package level config each time?

A quick test could be to add the following to your own settings.json and see whether that prevents the flashing?

"[vsnetrw]": {
  "editor.lineNumbers": "off"
}

It could also be the case that the extension mode isn't set initially, which causes the flash? In that case, I'm not sure what the workaround would be. It seems a little bit odd that there would be any time window where editor.lineNumbers was not "off".

If you get any more clues, do shout and I can look at what the fix might be.

from vsnetrw.

Hey @danprince, thanks for looking into it so quickly. Unfortunately, explicitly setting line numbers to off for vsnetrw in settings.jsondid not help. It seems these settings are set by default anyway (vscode suggested autocomplete).

It seems that vscode loads extension specific settings after the document has been loaded with the global settings.

What seems to work is to set line numbers to off globally, and then enable them for specific file types. I think this is good enough for me, there are not that many.

BTW, I love the extension, exactly what I've been looking for after not being able to use vim at work. Great job 👍

EDIT:
I just noticed that when a new directory is opened in vsnetrw, the file type briefly changes to plain text. Setting line numbers to off for plain text solves the issue. This way I can keep the line number enabled globally, and don't need to set them for different file types.

from vsnetrw.

BTW, I love the extension, exactly what I've been looking for after not being able to use vim at work. Great job 👍

🥳

Thanks for investigating! The plain text discovery was a great clue. It turns out the extension was setting the language type after showing the document. The order should be correct now.

I've published that change in v0.3.2, so feel free to try it out and see if it fixes that problem without a need for the workaround.

from vsnetrw.