Giter Club home page Giter Club logo

Comments (13)

danny-avila avatar danny-avila commented on May 20, 2024

Can you describe the issue more? I would like to allow model switching in existing conversation. If this creates an issue, we could have it have the same effect as clicking 'new chat'

from librechat.

wtlyu avatar wtlyu commented on May 20, 2024

I'm understand how you can switch model in existing conversation. The big issue is the conversationId, messageId and parentMessageId are all in different scope

from librechat.

wtlyu avatar wtlyu commented on May 20, 2024

How can we say the conversationId of all in one conversation? and the chatgpt will not keep memory of the previous talk

from librechat.

danny-avila avatar danny-avila commented on May 20, 2024

the way it currently works is it resets all of those parameters, and treats any further input from user as a new conversation, it does not continue the conversation. Even though the previous conversation is in view, the only way to go back to the 'previous' conversation state is to click on the convo again

from librechat.

wtlyu avatar wtlyu commented on May 20, 2024

another big issue is the messageId and parentMessageId chain is break. the behavior of standard and bing version gpt is not the same ,such as:

  1. chatgpt will accept our conversationId, it's a UUID, but bing version is not, it will always generated by server, a long string. and Sydney look same as chatgpt.
  2. chatgpt allow a nonsense parentMessageId to be used, but in bingai, new conversation will be created.

from librechat.

wtlyu avatar wtlyu commented on May 20, 2024

So literally , you are creating a totally new conversation, just combine them and show together

from librechat.

danny-avila avatar danny-avila commented on May 20, 2024

So literally , you are creating a totally new conversation, just combine them and show together

Yes, they are in just in view together, but they are separate conversations

from librechat.

wtlyu avatar wtlyu commented on May 20, 2024

I dislike this design and it make everything toooo complete to handle. I prefer to use something like a conversationGroup. which contains several conversation to render together.

from librechat.

danny-avila avatar danny-avila commented on May 20, 2024

A conversation group sounds more complicated to me. The view is only rendered together during the same session that the user switches the model, it's only temporary. When the user revisits a convo, only one model is ever present in the conversation. This seemed like the most simple solution to me, and I'd rather not over-engineer this functionality when they can be delegated to new convos

from librechat.

wtlyu avatar wtlyu commented on May 20, 2024

For now, this will break the messageTree. because messageId and parentMessageId chain are break.

And the resubmit is also confused on which model should be used. and what is the correct conversationId (maybe use the previous one?)

from librechat.

danny-avila avatar danny-avila commented on May 20, 2024

If that's the case, I think the simplest solution would be to just render a new message view on model switch, that would be the equivalent to clicking new chat, what do you think?

from librechat.

wtlyu avatar wtlyu commented on May 20, 2024

We should also review all frontend, check if the model variable is used correctly. (use convo.model or submit.model. mostly, use convo.model is the correct one.)

Another easy solution is disable the model switch within conversation. Canbe changed only in new chat view.

from librechat.

wtlyu avatar wtlyu commented on May 20, 2024

now changing model will create new conversation

from librechat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.