Giter Club home page Giter Club logo

Comments (12)

paulmillr avatar paulmillr commented on June 16, 2024 2

Soon, noble-hashes would be extremely popular. Most ethereum projects should include it because it'll be included in "main lib".

We're waiting for the security audit now.

from hash-wasm.

Daninet avatar Daninet commented on June 16, 2024

Hey. I added it to my benchmark tool here: https://daninet.github.io/hash-wasm-benchmark/
Blake3 seems to be missing from the npm package. Feel free to create a PR to add a test for that as well.

from hash-wasm.

paulmillr avatar paulmillr commented on June 16, 2024

@Daninet readme is missing it though

from hash-wasm.

Daninet avatar Daninet commented on June 16, 2024

I try to keep the readme file short. I want to only add the most popular libraries on NPM and those which are based on WASM so they are comparable in performance.

from hash-wasm.

Daninet avatar Daninet commented on June 16, 2024

Okay, I will consider adding it to the next version.

from hash-wasm.

paulmillr avatar paulmillr commented on June 16, 2024

Thanks Dani!

from hash-wasm.

paulmillr avatar paulmillr commented on June 16, 2024

@Daninet I think it's unreasonable to benchmark toHex function. It slows down the benchmark by at least 40%. Can you remove the last line?

https://github.com/Daninet/hash-wasm-benchmark/blob/master/src/benchmark/sha256.worker.js#L56

I also don't see any util in manipulating an array of bytes in hex form instead of Uint8Array form.

from hash-wasm.

paulmillr avatar paulmillr commented on June 16, 2024

BTW, 0.3.0 is out, with blake3.

from hash-wasm.

Daninet avatar Daninet commented on June 16, 2024

To make the fair assessment, I ask for hexstring output from all libraries. In this way I make sure that I compare apples to apples.
Hexstring was chosen because all libraries does not support Uint8Array digests. Also hexstrings are still a very common and practical format for visualizing hashes.

from hash-wasm.

paulmillr avatar paulmillr commented on June 16, 2024

@Daninet i've sped up toHex conversion in 0.3 which would show more confident numbers in your benchmarks.

from hash-wasm.

Daninet avatar Daninet commented on June 16, 2024

Now I get incorrect hashes with 0.3 😢. My benchmark tool also compares the results...

from hash-wasm.

paulmillr avatar paulmillr commented on June 16, 2024

Fixed with 0.3.1 @Daninet

from hash-wasm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.