Missing files from repo about bitburner HOT 9 CLOSED

Thanks @danielyxie for adding the license, webpack.config & package.json. Although I think that raises a lot more questions for me now than it answered.

Originally I brought it up because I wanted to see if I could detangle the code and try it in a front-end framework other than jQuery (purely for a "see if I can do it/try out a specific UI framework" pet project). Which would require some linting, tests, and breaking down the inter-dependencies between files. But it looks like you have much of that covered based on the packages & scripts called out in those files, just not in the repo.

And given the license is essentially the Doom Source License rather than a SPDX/OSI recognized one I guess my pet project will remain purely my own 😢

from bitburner.

It looks like the package.json I uploaded doesn't actually work. I just tried to setup a new dev environment and not all dependencies were installed. I'll try to fix this when I get some time

The license I added was recommended by someone else. I'm open to changing it if you have any suggestions/preferences. The only requirement I have is that its noncommercial. Essentially something along the lines of "you can do whatever you want with the code, as long as you dont make any money off of it or from derivative works".

from bitburner.

Although Creative Commons typically isn't as a source code license, it seems like you're looking for CC-BY-NC-SA-4.0 (SPDX License or Human readable version. It's more permissive and denies commercial use directly (and from derivatives). There are other lesser known licenses that may cover it, but most open source licenses cover attribution and intellectual property claims more than commercial use.

But I'm no lawyer -- and ultimately it is your code & project -- so it's your call.

from bitburner.

I was actually looking at some Creative Commons licenses at first but didn't use them because they explicitly recommend against using it for software in their FAQ.

Which specific permissions are you looking for? It sounds like distribution is one, but is there anything else?

from bitburner.

I usually use MIT, Apache or GPL, which are compared here. MIT is the shortest of the three and usually serves my purposes.

from bitburner.

I'm not super good at understanding legal-ese but that license seems to prevent anyone from making and sharing spin-off versions even just for their own learning. It also seems to block altering the code and making contributions so we would not be able to make additions or help fix bugs and submit pull requests (I might just be understanding it wrong though...).

As for the package.json it looks like you just added the one for webpack itself. I know that one major problem is npm wont let you install webpack with that package.json because the name inside it is "webpack". I would suggest checking to make sure none of the packages you use for this project were installed globally or just not saved when installed.

(Also it seems that the specially built brace/mode/netscript is still missing)

from bitburner.

Agree with what @jjspace wrote. Even paragraph 3 seems to suggest one could still make money off the software under the guise of saying you did it for educational reasons. Also in Paragraph 4 you forgot to update a line, so technically all the source is owned & copyright Id software.

And from what I reverse-engineered to recreate the webpack file, that brace/mode/netscript is the only one I couldn't figure out what content was supposed to be in there. Looking back over my commit log I introduced webpack back in after some heavy ESLint cleanup and bringing in TypeScript (and not realizing how many circular dependencies are in the code yet at that point).

from bitburner.

Ok I updated the license. Obviously I'm not experienced with legal stuff either, but if it still seems like its not permitting modification/educational sharing let me know.

Also updated the package.json. I'm confident it's not a proper package.json file since it's still under the "webpack" name but it works and I'll read into getting a proper one set up.

Added the netscript.js file into the repository's root folder.

from bitburner.

Based on the merged PR, I think the general files that I felt were missing initially have been taken care of. I think there's others that should probably be there from a collaboration/contribution perspective (EditorConfig and linting tools come to mind). Those can be a separate issue to resolve them.

So I'm going to close this one.

from bitburner.