Giter Club home page Giter Club logo

Comments (2)

edemaine avatar edemaine commented on September 25, 2024 1

Thanks for the detailed analysis! This was very clear. Should be implemented in v0.6.61, along with fixed watch mode in esbuild and fixes for Windows.

from civet.

imm avatar imm commented on September 25, 2024

Regarding ESBuild. It looks like the problem was in the esbuild options, since the emitFile method for ESBuild rely only on the outdir option, but not on outfile (see last if here). If we change options in esbuild.js to this

const options = {
  entryPoints: ['src/main.civet'],
  bundle: true,
  outdir: 'dist',
  plugins: [civetEsbuildPlugin({
    ts: 'esbuild',
    emitDeclaration: true
  })],
}

then the type declarations will be written to files. It was very unobvious.

It is logical that if only outfile is specified then it is not clear where to write additional files. It's a shame this happens silently. It may be possible to add some kind of check for this in the plugin with a warning that when the outfile option is specified instead of outdir it is impossible to generate type declarations.

Interestingly, in the case of ESBuild the current version with asynchronous callback works but for Rollup it doesn’t. It works with a synchronous callback in both cases.

from civet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.