Giter Club home page Giter Club logo

Comments (4)

STRd6 avatar STRd6 commented on May 26, 2024

I think it has to do with caching. Since the "civet coffeeInterpolation" prologue directive changes the behavior of strings if it is followed by a string it may be parsed and cached. I'd prefer to not add strings to the non-cached list since that could affect parsing performance throughout the whole file.

Fine tuning the directive prologue parsing to only check for simple strings may fix this.

from civet.

STRd6 avatar STRd6 commented on May 26, 2024

It may be an open question whether we should mangle top level directive prologues. In this case "Hello #{name}!" is parsed as a JS prologue in the spec and probably shouldn't be interpolated no matter what civet config options are specified.

from civet.

edemaine avatar edemaine commented on May 26, 2024

Oh, I forgot about JS prologues. This behavior makes sense then, I think.

It might make sense to just clear the cache after parsing the Civet directive, though I'm not sure whether this is ever an issue.

from civet.

STRd6 avatar STRd6 commented on May 26, 2024

I probably need to add a comment in the parser since I forgot about it until reading the code :)

from civet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.