Giter Club home page Giter Club logo

Comments (4)

TimothyBJacobs avatar TimothyBJacobs commented on June 7, 2024 1

@budley We're pushing a fix to add the noopener rel to links instead of using blankshield for browsers that support the noopener property.

from blankshield.

Manours avatar Manours commented on June 7, 2024

I've got the same problem since Chrome 72.
Maybe because of that : https://www.chromestatus.com/feature/5989473649164288

from blankshield.

budley avatar budley commented on June 7, 2024

Same here - the library seems to be included in a WordPress security plugin called iThemes Security and so is breaking lots of sites via that (well, Chrome's change is - not the author's fault). If it can't be fixed could you let us know please then I can maybe let iThemes know so they can pull that feature (that many people might not be aware is causing their sites problems!). Thanks.

from blankshield.

meeq avatar meeq commented on June 7, 2024

https://bugs.chromium.org/p/chromium/issues/detail?id=844455

https://html.spec.whatwg.org/#apis-for-creating-and-navigating-browsing-contexts-by-name

The window open steps, given a string url, a string target, and a string features, are as follows:

  1. If the event loop's termination nesting level is nonzero, return null.

I assume this is happening because the iframe is removed immediately after it's added, which Chrome now considers a pop-up during unload:

blankshield/blankshield.js

Lines 187 to 190 in 6e208bf

iframeDoc.body.appendChild(script);
newWin = iframe.contentWindow.child;
document.body.removeChild(iframe);

Edit: Even if L190 is removed, the pop-up blocker is still triggered.

from blankshield.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.