Comments (5)
Hello,
I have a pull request from a fellow contributor that does this #2
If you test it and it works for you I'll merge it it. Based on a visual review it looks good. Lots of formatting checkins which makes it harder to check. My only comment on it is that the recursive nature is not passed as a parameter to make it optional.
from aws-s3-zipper.
This is awesome. Thanks for the quick response!
I'll test and get back to you shortly.
from aws-s3-zipper.
ok - it did work, but I now have a different error:
/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/request.js:30
throw err;
^
TypeError: Cannot read property 'ETag' of undefined
at /Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/index.js:224:44
at ManagedUpload.callback (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/index.js:203:21)
at Response.finishSinglePart (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/s3/managed_upload.js:568:28)
at Request.<anonymous> (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/request.js:354:18)
at Request.callListeners (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/sequential_executor.js:105:20)
at Request.emit (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
at Request.emit (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/request.js:596:14)
at Request.transition (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/request.js:21:10)
at AcceptorStateMachine.runTo (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/state_machine.js:26:10
Pretty sure this is a completely different issue. So, if you're looking to merge in that pull request, you're probably good to go. Thanks again for the help.
from aws-s3-zipper.
there is a conflict. I'm checking it now
from aws-s3-zipper.
try version 1.0.1
from aws-s3-zipper.
Related Issues (20)
- Use file ~/.aws/credentials to authenticate on S3 service
- Zip creation of large folder on S3 using aws-s3-zipper and Node js HOT 3
- Breaking Unexpectedly HOT 5
- Not an issue: Tumblr is using this in production HOT 1
- Breaking in AWS instance
- zipToS3File throws error when deleting temp file
- Is accessKeyId and secretAccessKey required to get zipper object
- Root folder possible?
- Authorisation mechanism not supported
- Hitting this error: (.d.ts) file containing `declare module 'aws-s3-zipper' ?
- Corrupted zip file result in zipToS3File
- should it get credentials from AWS.config?
- cannot run with nodejs.12X environment HOT 3
- Does this stream to Fragments for download?
- zipToFileFragments: maxFileCount not produced results as expected?
- Recursive key doesn't works
- how to change it use at typescript?
- Fix endpoint & add s3PathStyle
- console full of debugging statements from aws s3 zipper
- RAM did not release if downloading was cancelled and files are corrupted after complete download using streamZipDataTo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-s3-zipper.