Giter Club home page Giter Club logo

Comments (5)

DanielHindi avatar DanielHindi commented on June 5, 2024 1

Hello,

I have a pull request from a fellow contributor that does this #2

If you test it and it works for you I'll merge it it. Based on a visual review it looks good. Lots of formatting checkins which makes it harder to check. My only comment on it is that the recursive nature is not passed as a parameter to make it optional.

from aws-s3-zipper.

4fthawaiian avatar 4fthawaiian commented on June 5, 2024

This is awesome. Thanks for the quick response!

I'll test and get back to you shortly.

from aws-s3-zipper.

4fthawaiian avatar 4fthawaiian commented on June 5, 2024

ok - it did work, but I now have a different error:

/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/request.js:30
            throw err;
            ^

TypeError: Cannot read property 'ETag' of undefined
    at /Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/index.js:224:44
    at ManagedUpload.callback (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/index.js:203:21)
    at Response.finishSinglePart (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/s3/managed_upload.js:568:28)
    at Request.<anonymous> (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/request.js:354:18)
    at Request.callListeners (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/sequential_executor.js:105:20)
    at Request.emit (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/request.js:596:14)
    at Request.transition (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/request.js:21:10)
    at AcceptorStateMachine.runTo (/Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /Users/bradleymccrorey/lambdazip/node_modules/aws-s3-zipper/node_modules/aws-sdk/lib/state_machine.js:26:10

Pretty sure this is a completely different issue. So, if you're looking to merge in that pull request, you're probably good to go. Thanks again for the help.

from aws-s3-zipper.

DanielHindi avatar DanielHindi commented on June 5, 2024

there is a conflict. I'm checking it now

from aws-s3-zipper.

DanielHindi avatar DanielHindi commented on June 5, 2024

try version 1.0.1

from aws-s3-zipper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.