Hey there! I have faced an interesting issue. I've

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

[Bug?]: Inconsistent schemas generation. about huma HOT 2 OPEN

superstas commented on July 23, 2024

[Bug?]: Inconsistent schemas generation.

from huma.

Comments (2)

krisatverbidio commented on July 23, 2024

I think it is because T is a slice in your In type. I'm not sure of the correct solution for how to get Huma to dig into your slice, but maybe you need to make a special schema type just for that reason.

But minLength and maxLength are not valid for slices, so that is most likely why it's not coming back.

from huma.

superstas commented on July 23, 2024

@krisatverbidio, I'm not sure I got your point.

But minLength and maxLength are not valid for slices
The thing is, In type received minLength and maxLength for each item

type In[T huma.SchemaProvider] struct {
	Operator string `json:"operator" enum:"IN" doc:"The operator to use for the comparison."`
	Values   []T    `json:"values" doc:"The values to compare against."`
}

generates

    InSpecialString:
      additionalProperties: false
      properties:
        operator:
          description: The operator to use for the comparison.
          enum:
            - IN
          type: string
        values:
          description: The values to compare against.
          items:
            description: A special string type.
            maxLength: 255
            minLength: 1
            type: string
          type: array

Which is expected.

But, this one

type Equal[T huma.SchemaProvider] struct {
	Operator string `json:"operator" enum:"EQUAL" doc:"The operator to use for the comparison."`
	Value    T      `json:"value" doc:"The value to compare against."`
}

for some reason doesn't have it.
I would expect to get smth like

    EqualSpecialString:
      additionalProperties: false
      properties:
        operator:
          description: The operator to use for the comparison.
          enum:
            - EQUAL
          type: string
        value:
          description: The value to compare against.
          maxLength: 255 <-- missed
          minLength: 1 <-- missed
          type: string
      required:
        - operator
        - value
      type: object

Does it make sense?

from huma.

Recommend Projects