Comments (2)
@srilman thanks for the issue! I believe this was done on purpose because Go can't use reflection to access private fields from other packages, so it would be inconsistent to allow access from within your package but disallow it from imported packages. I can dig a bit deeper just to confirm this is the case with embedded private fields.
from huma.
And from my understanding, to change this behavior, we just need to change function getFields
in file huma/schema.go
:
func getFields(typ reflect.Type, visited map[reflect.Type]struct{}) []fieldInfo {
fields := make([]fieldInfo, 0, typ.NumField())
var embedded []reflect.StructField
if _, ok := visited[typ]; ok {
return fields
}
visited[typ] = struct{}{}
for i := 0; i < typ.NumField(); i++ {
f := typ.Field(i)
if !f.IsExported() {
continue
}
if f.Anonymous {
embedded = append(embedded, f)
continue
}
fields = append(fields, fieldInfo{typ, f})
}
for _, f := range embedded {
newTyp := f.Type
for newTyp.Kind() == reflect.Ptr {
newTyp = newTyp.Elem()
}
if newTyp.Kind() == reflect.Struct {
fields = append(fields, getFields(newTyp, visited)...)
}
}
return fields
}
All to change is move this snippet:
if !f.IsExported() {
continue
}
underneath the if statement if f.Anonymous {
from huma.
Related Issues (20)
- Question about 'required by default' HOT 5
- Adding openapi command still emits router config HOT 2
- Accessing file name and file size in `multipart/form-data` request HOT 1
- Data race when consuming input RawBody HOT 1
- Routing groups in Go 1.22 HOT 2
- Discussion: How best to catch and log 500s? HOT 2
- Panic on Validation Phase of custom `time.Time` Type HOT 2
- Does readOnly actually do any validation? HOT 1
- Setting headers in error response always appends HOT 2
- fmt.Println message: warning: unable to set write deadline HOT 1
- Panic on write with very large response body bricks server for some time as response body is logged to standard output HOT 1
- Applying common headers to multiple responses (doc's issue)
- Response struct without a "Body" field is silently ignored if using Register HOT 1
- Make huma play well with custom error types returned from handlers
- Humagin multiple API's per route group? HOT 1
- Returning nil as response body causes 500
- Can I use net/http.Handler directly?
- custom validation tags with constraints specified in the spec.
- Handling of custom types for List inputs of query params
- Suggestion: groups and sub-routing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from huma.