Doesn't install anything about reactphysics3d HOT 16 CLOSED

Hello. Yes "make install" is not implemented yet. What kind of behavior do you want ? Installing the compiled library somewhere in your system ? Installing the testbed application ? Both ?

from reactphysics3d.

Installing library/headers under $DESTDIR/$PREFIX.

from reactphysics3d.

Thanks. I will try to implement this.

from reactphysics3d.

You can look at any other cmake project. cmake has INSTALL instructions, that's all that needs to be done. headers/libraries/man pages/icons are installed.

from reactphysics3d.

Add instal target in CMake file to install the compiled library and header on the system

from reactphysics3d.

This is now done in the version v0.7.0 of ReactPhysics3D that has just been released.
Thanks a lot for reporting this.

from reactphysics3d.

Now the version 0.7.0 only installs lib/libreactphysics3d.a and no headers.

from reactphysics3d.

Also, ADD_LIBRARY(reactphysics3d STATIC ${REACTPHYSICS3D_HEADERS} ${REACTPHYSICS3D_SOURCES}) always installs the static library. Usually, cmake projects use the BUILD_SHARED_LIBS option to control the type of library to build: https://cmake.org/cmake/help/v3.0/variable/BUILD_SHARED_LIBS.html

from reactphysics3d.

This prevents me from creating a FreeBSD port for reactphysics3d
.

from reactphysics3d.

I have pushed a fix into the fix37 branch.
Can you try on your side if the bug is now fixed ?

Best regards

from reactphysics3d.

Now it installs headers and the shared library. One problem: the library shouldn't be in a subdirectory: lib/reactphysics3d/libreactphysics3d.so should be lib/libreactphysics3d.so.

from reactphysics3d.

That's right. I have just pushed a fix in the same branch.
Can you test if it is ok now ?

from reactphysics3d.

Yes, it's fine now.

One thing that can be further improved is to create symbolic links for the shared library:

libreactphysics3d.so.0.7.0 -> libreactphysics3d.so
libreactphysics3d.so.0.7 -> libreactphysics3d.so
libreactphysics3d.so.0 -> libreactphysics3d.so

libreactphysics3d.so.0 or libreactphysics3d.so.0.7 should be a SONAME. Any incompatible, non-incremental changes to the interface should trigger the SONAME change.

from reactphysics3d.

I have just added the VERSION and SOVERSION to the CMakeLists.txt with this commit in the fix37 branch.

Is it what you expect ?

from reactphysics3d.

Yes, this is exactly what I've asked for!
Thanks!

from reactphysics3d.

Thanks for reporting this. I have just merged the fix37 branch with the fix into master.

from reactphysics3d.