Giter Club home page Giter Club logo

Comments (6)

DanielBok avatar DanielBok commented on September 21, 2024

Hello,

Addressing 2 issues:

  1. You see the same random variables because of the seed
  2. The cdf is a 1-to-1 transformation so given any input, it should return deterministically the same output

That said, after reviewing the code, I noticed I made a mistake with the random generation in that I should have sampled the data with replacement. I'll fix it in the next update.

from copulae.

M-Soundouss avatar M-Soundouss commented on September 21, 2024

Hello,

Thanks for your response.
Sorry I was not clear enough, what I meant is that :

print(cop.cdf(np.array([[0.1, 0.5, 1.]])))

# Gives [0.13366667]

print(cop.cdf(np.array([[0.1, 1., 1.]])))

# Gives [0.13366667]

print(cop.cdf(np.array([[1., 1., 1.]])))

# Gives [0.13366667]

I understand that cdf is deterministic but it does not mean that it should map all possible inputs into 0.13366667, right?

This behavior is different from other types of copulae (like the normal one) where the cdf function gives the output I expected.

from copulae.

DanielBok avatar DanielBok commented on September 21, 2024

Yes, you're right. Thank you for pointing out the bug.

The issue arises because I was trying to make it convenient by auto-adjusting the data into pseudo-observations when it is not already so. When I take it away, it'll be correct. I'll release the fix in the next copy.

from copulae.

M-Soundouss avatar M-Soundouss commented on September 21, 2024

Thank you very much! Looking forward to it.

from copulae.

DanielBok avatar DanielBok commented on September 21, 2024

@M-Soundouss I pushed up a fix in 0.7.0.

from copulae.

M-Soundouss avatar M-Soundouss commented on September 21, 2024

Thank you very much!

from copulae.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.