Module 'url' not found about bw_web_builds HOT 6 CLOSED

Check the changes done here: 9efb207

You probably still have the npm audit --fix which produces this issue.

from bw_web_builds.

I just tried my build process without the npm audit --fix and it succeeded. I'm no node expert but isn't it better to fix the audit fix by adding the required package than to skip it ?

from bw_web_builds.

It probably is. But we do not develop the web-vault our selfs, we just make some patches and build it.

from bw_web_builds.

I understand, but the change I proposed could be added to the patch (I only added a line to packages.json), and we could keep the audit --fix (if not I can add it myself to my build chain, but others could benefit from the security of audit).

from bw_web_builds.

Well, we do not know the reason specifically they still use that older version. Maybe there is a reason to it, maybe not.
The audit -fix was an addition already, which in the end broke with this specific version. Who know what other items could break. You are free to try of course, but i think we should stay as close as possible to the same build environment and versions used by Bitwarden it self to prevent weird issues from appearing.

from bw_web_builds.

This issue is outdated i think, especially since v2022.6.x has this solved already, and uses a slightly different way of building.
@hybris42 (or @dani-garcia ) could you please close this issue 😄 thanks.

from bw_web_builds.