Terminal size is off by one on Linux about delta HOT 9 CLOSED

I figured it out, it was my ~/.lesskeyrc -- I have -J or --status-column enabled which reduces the width by one character. I wonder if it would be possible to detect it, or have a way to override.

from delta.

Hm, this was supposed to have been fixed in v0.0.13 by #22. Let's get to the bottom of this!

I'm not managing to reproduce yet in MacOS iTerm2 with delta 0.0.14. Here's a little experiment. Notice how, in the first case, delta is leaving one character of space unused at the right edge of the terminal. This is what is should always do by default, since #22. In the second case, less is invoked with -J, and so it inserts an extra space in the left column, but the lines do not overflow on the right because of the extra space which was left there for this reason.

Can you reproduce this? (If not, can you double check the version of delta that is being invoked by git (maybe pipe git output into a delta executable explicitly) and post the relevant contents of your ~.lesskey).

With LESS environment variable equal to empty string (export LESS=):

With export LESS=-J:

from delta.

Also, if it's still mysterious, could you post the values of the environment variables PAGER, BAT_PAGER and LESS?

from delta.

Notice how, in the first case, delta is leaving one character of space unused at the right edge of the terminal. This is what is should always do by default, since #22. In the second case, less is invoked with -J, and so it inserts an extra space in the left column, but the lines do not overflow on the right because of the extra space which was left there for this reason.

Well, in my case less -J adds two spaces:

$ less --version
less 531 (PCRE regular expressions)
Copyright (C) 1984-2017  Mark Nudelman

I've built git-delta from the sources attached to the release: https://github.com/dandavison/delta/archive/0.0.14.tar.gz

$ delta --version
delta 0.0.14

My .lesskeyrc : LESS=-imJMWR

My environment:

$ env | grep -i -e '\(less\|pager\)'
LESS=-R -M --shift 5
LESSCOLOR=yes
LESSOPEN=|/usr/bin/lesspipe.sh %s
MANPAGER=manpager
PAGER=/usr/bin/less

I've unset all of my environment and removed the lesskey file, and tried the pipe mode:

$ env | grep -i -e '\(less\|pager\)'
MANPAGER=manpager
PAGER=/usr/bin/less
$ git show --color=always | delta

And with LESS=-J:

$ git show --color=always | LESS=-J delta

I've also tried the the latest commit, which gives me the same behaviour:

$ git describe --tags
0.0.14-1-gba454ba

This is inside tmux.

from delta.

I did a bit of digging, it appears to have changed in version 525 of less:

gwsw/less@0a150b3#diff-94003069247e17a040faa638addca45cR166

from delta.

Thanks! Should be fixed in master by #43, would you be able to confirm?

from delta.

This is exactly the path I was using as a workaround ;-)
I've built and tested the latest master -- looking good, thank you very much for fixing it promptly.

$ git describe --tags
0.0.14-5-g4b7bbdd

from delta.

I noticed the same (without using any arguments to less), but the effect appears to depend on the theme. I remember that the output was fine with --dark, but broken in this way with --light. I am currently on a different monitor (different resolution) and cannot reproduce it here, though.

from delta.

@fdcds thanks! Do please let us know if you see this problem with the current version.

from delta.