🐛 Always using light theme on dark background about delta HOT 9 OPEN

I tried again with GNOME terminal this morning and it is working as expected. Maybe I didn't start a new session or something last night after trying to force the dark theme. Sorry about that. So that just leaves Zellij.

The workaround of setting dark = true in the .gitconfig works, though! Thanks!

from delta.

That's great to hear! I was worried there for a second since GNOME Terminal always worked well in my experience 😆

from delta.

Hi @EbonJaeger, sorry about that. Please add dark = true or --dark to your delta config / invocations to force colors for dark backgrounds.

delta in 0.17.0 should autodetect in the absence of the light/dark setting. I wonder if it could be an issue with Zellij cc @bash -- any thoughts?

from delta.

I'm seeing the same issue but only when I'm inside a tmux shell. Outside tmux it works fine.

from delta.

Hi @EbonJaeger 👋 Thank you for reporting the bug!
In your GNOME Terminal setup, are you running Bash inside of Zellij or directly in GNOME Terminal?

I would be surprised if the issue happened in GNOME Terminal directly as it has always correctly reported colors in my experience.

@dandavison From a quick glance and some preliminary tests it does seem like Zellij reports incorrect colors (happens to me both in Alacritty and GNOME Terminal). If will try to dig further next week or so.

from delta.

@rsmmr What version of tmux are you running? Color detection should work OK in the latest version from git iirc.

from delta.

@bash I was not using Zellij or tmux in GNOME terminal; just straight Bash. I'll try the workaround later. 😃

from delta.

I've hit this too. It works fine in tmux, but not in zellij. What's more annoying is that the new --detect-dark-light flag cannot be set through gitconfig, which means my only option is to force dark on all the time instead of letting it infer from my theme.

from delta.

Also I will note that Zellij sets a few env vars that can be used to detect that we're running in Zellij.

from delta.