Giter Club home page Giter Club logo

Comments (3)

mouseless-eth avatar mouseless-eth commented on August 10, 2024 1

Looks good! Options A & B have a much cleaner api interface, personally I would lean more towards them. Much better to let the bundler/compressor-endpoint handle registration of inflators, this also means less work/overhead for the people that want to use the endpoint.

"Separately, as an optimization, it's possible to do the inflator-registering and bundle-submitting in a single atomic multicall." this is a interesting observation on your end, very useful property.

Curious to hear your thoughts on Issue #4 (Make a compress view function for each inflator), if done correctly the implications would mean that you can send uncompressed UserOp/s to the bundler and the bundler can compress the request before sending it to the BundleBulker. This is even less overhead/templating on the users/dapps end as they no longer need to self compress their userOps.

Extending on issue #4:

Would it make sense to let the BundleBulker handle compression/decompression of common fields like sender, maxFeePerGas, maxPriorityFeePerGas, and nonce_key. This reduces code copy across each inflator implementation. This also means that each inflators just needs methods to handle the compression/decompression of calldata, signature, and paymaster.

Although going this route does kill composability as a template is forced onto users that want to use the BundleBulker.

from bulk.

dcposch avatar dcposch commented on August 10, 2024
  • A/B sounds good to me. B matches the 4337 standard eth_sendUserOperation API call, so I'd lean toward that.
  • #4 might be a nice implementation choice for many IOpInflators, but I would definitely recommend having the API take compressed ops. Fewer moving parts, and leaves it optional.
  • Valuable for BundleBulker to stay very simple & unopionated. In our prototype so far, we get a lot of mileage out of eliminating fields entirely in the compressed representation, then templating them in with constants. I don't think there's a one-size way to handle these. See for example: https://github.com/daimo-eth/daimo/blob/master/packages/daimo-api/src/network/bundleCompression.ts#L47-L135

...however, we could write a generic IOpInflator that's a reasonable default for a lot of apps. This would make it easy for other apps to adopt compression.

from bulk.

dcposch avatar dcposch commented on August 10, 2024

V1 / Option D

Shipping:

pimlico_sendCompressedUserOperation(
   compressedCalldata, // hex bytes
   targetOpInflatorAddress, // hex address
   entryPointAddress // hex address
)

Returns userOpHash, or a descriptive error message.

For now, user registers their IOpInflator ahead of time.

from bulk.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.