Comments (1)
I would veto that IMHO. My preference would still be having something I described in #6.
Reasons:
The author of the commands has better insights into the needed circuitbreaker options than a "user" of the commands (The commands could come in library and are just used a client-lib by some other service).
Also I don't want to copy&paste the options-creation code-snippet to every place that initialized the command (the same command could be used at multiple places).
We maybe should make a list of all the options we have first - I was just thinking that we may want to set certain options like the circuitbreaker globally and not per-command?
How is the circuit breaker currently found/shared? Per group+command-name?
from gohystrix.
Related Issues (16)
- Make Fallback() optional HOT 1
- Use the httpexp to render a graph similar to the nexflix dashboard
- Get the nested error when a fallback error is returned
- Option to send the metrics by statsd or similar, instead of storing a sample in memory HOT 4
- Expose all circuit breakers HOT 3
- Add a way to define a command with a function HOT 2
- refactor to use juju errgo for error handling HOT 1
- cancel the go routine when a timeout is reached
- Add a way to cancel the request that is timeming out.
- Circuit breaker not resetting HOT 2
- License? HOT 1
- ErrorPercetageThreshold on README.md
- Call Fallback() if Run() fails
- Simplify command interface HOT 2
- benchmark the impact over normal calls, in time and memory
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gohystrix.