Giter Club home page Giter Club logo

Comments (5)

jamiedemaria avatar jamiedemaria commented on July 22, 2024

cc @smackesey if you've run across this before or have any ideas? @gibsondan you've also been looking at pendulum stuff recently right?

From what I can find through searching around, pendulum claims to have fixed this in sdispater/pendulum#53, but it was part of the 0.6.2 release in 2016, so you should definitely have that code.

Other libraries that ran into the same issue, seem to write custom code to special case negative time on windows:

This PR from py-arrow uses timedelta if the date is negative and the OS is windows

Another example from faker joke2k/faker#1436

from dagster.

smackesey avatar smackesey commented on July 22, 2024

IIUC @gibsondan has a PR that removes pendulum entirely so hopefully that will make this issue moot

from dagster.

gibsondan avatar gibsondan commented on July 22, 2024

We are going to remove pendulum, but we will still be using UNIX timestamps after that, so I'm not positive that will resolve this.

from dagster.

gibsondan avatar gibsondan commented on July 22, 2024

It's possible that the workaround suggested here could resolve this, but I have not tried it: https://stackoverflow.com/questions/37494983/python-fromtimestamp-oserror/41400321#41400321

from dagster.

jamiedemaria avatar jamiedemaria commented on July 22, 2024

yeah, after some internal discussion, this is something we aren't going to try to fix. We assume we can use unix timestamps all over our code base, so trying to work around this issue is infeasible at the time. Closing this issue

from dagster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.