Comments (18)
dabeaz
commented on August 22, 2024
Would need more details. The lextab and tabmodule arguments to PLY really are meant to be strings containing the names of the lextab and parsetab modules. I quickly looked at the source code to slimit and don't see where it is doing anything different. Maybe I'm missing something.
from ply.
byyo
commented on August 22, 2024
This line in slimit ends up passing the module itself instead of the string down to the lex module: https://github.com/rspivak/slimit/blob/master/src/slimit/parser.py#L56
which calls https://github.com/rspivak/slimit/blob/master/src/slimit/lexer.py#L102
from ply.
dabeaz
commented on August 22, 2024
Looking at it. Hmmm. I'll be honest, I'm not super keen on supporting this passing of the bare module objects like that (although apparently past versions of PLY allowed it for some reason). Let me ponder it further.
from ply.
byyo
commented on August 22, 2024
IMHO if you don't want to support handling the bare module the version number should bump up to 4.0, since this is technically an API change
from ply.
NormalRa
commented on August 22, 2024
Pepper Plugin API where its IDL lexer makes a call also exhibits the same a similar issue. This may cause building Android to fail.
from ply.
dabeaz
commented on August 22, 2024
I'm going to fix this, but I'm going to wait another 4-5 days for a release just to see if other issues come in.
from ply.
The-Compiler
commented on August 22, 2024
FWIW this also breaks building of Chromium, due to the issue reported by @NormalRa above.
from ply.
NormalRa
commented on August 22, 2024
Ah yes, bleeding-edge distributions. We are guinea pigs! c:
from ply.
dabeaz
commented on August 22, 2024
I've pushed a fix to github. Would appreciate some testing.
from ply.
The-Compiler
commented on August 22, 2024
It's unfortunately still broken when building Chromium:
File "../../../tools/json_schema_compiler/compiler.py", line 191, in <module>
opts.namespace, opts.impl_dir, include_rules)
File "../../../tools/json_schema_compiler/compiler.py", line 128, in GenerateSchema
code = generator.Generate(namespace).Render()
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/h_generator.py", line 17, in Generate
return _Generator(namespace, self._type_generator).Generate()
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/h_generator.py", line 62, in Generate
.Cblock(self._type_helper.GenerateIncludes(include_soft=include_soft))
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/cpp_type_generator.py", line 163, in GenerateIncludes
for namespace, dependencies in self._NamespaceTypeDependencies().items():
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/cpp_type_generator.py", line 208, in _NamespaceTypeDependencies
hard=not prop.optional)
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/cpp_type_generator.py", line 231, in _TypeDependencies
deps.add(_TypeDependency(self._FindType(type_.ref_type), hard=hard))
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/cpp_type_generator.py", line 175, in _FindType
self._default_namespace)
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/schema_loader.py", line 76, in ResolveType
namespace = self.ResolveNamespace(full_namespace)
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/schema_loader.py", line 64, in ResolveNamespace
self.LoadSchema(filepath)[0],
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/schema_loader.py", line 90, in LoadSchema
api_defs = idl_schema.Load(schema_path)
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/idl_schema.py", line 525, in Load
return Process(contents, filename)
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/idl_schema.py", line 535, in Process
idl = idl_parser.IDLParser().ParseData(contents, filename)
File "/tmp/yaourt-tmp-florian/aur-chromium-dev/src/chromium-44.0.2383.0/tools/json_schema_compiler/../../ppapi/generators/idl_parser.py", line 908, in __init__
optimize=0, write_tables=0)
File "/usr/lib/python2.7/site-packages/ply/yacc.py", line 3214, in yacc
if '.' not in tabmodule:
TypeError: argument of type 'NoneType' is not iterable
from ply.
dabeaz
commented on August 22, 2024
Why is it passing a tabmodule of None? That is not documented nor is it the default value for that argument.
from ply.
The-Compiler
commented on August 22, 2024
I have no idea, I just know it works when I install ply 3.4 😄
I also opened this Chromium issue but so far nothing happened except of someone adding a NeedsFurtherTriage tag.
from ply.
lelit
commented on August 22, 2024
Slimit runs ok, with latest patch, thank you.
from ply.
dabeaz
commented on August 22, 2024
Have made an additional patch to try and fix this.
from ply.
protist
commented on August 22, 2024
Thanks for this fix. With ply 3.6, I couldn't build qt5 from source, in Arch Linux. The latest git version of ply fixes this.
from ply.
gsingh93
commented on August 22, 2024
So Ply 3.7 fixes this issue, right? The latest version I can install with pip is 3.6, and that still seems to have the issue. Can you update this on pypi?
from ply.
dabeaz
commented on August 22, 2024
Download ply-3.7 and see if it fixes the issue.
from ply.
gsingh93
commented on August 22, 2024
@dabeaz it does. I also see you've updated the pypi version to 3.8, thanks.
from ply.
Related Issues (20)
- Warn user about tuple flattening in precedence table HOT 3
- PyPI package HOT 2
- Trying to get in touch regarding a security issue
- "global flags not at the start of the expression" error when using in-line global regex flag with Python 11+ HOT 1
- Please make a new release HOT 1
- PLY not compatible with python 3.12 HOT 1
- extreme slowness HOT 5
- Read grammar from files HOT 2
- Re examples/ansic HOT 1
- lextab.py and yacctab.py HOT 13
- Exporting gramma for documentation
- ssl cert issue for the website
- License HOT 2
- "state" is ambiguous in the documentation. HOT 1
- lex.lex() can get some rules in the wrong order. HOT 1
- Documentation in doc/ply.md lacks important details about creating a custom lexer. HOT 6
- Import several module with lex()
- allow user actions in debug mode HOT 1
- Add MIT License
- PLY VHDL parser not producing a parser tree... HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ply.