Giter Club home page Giter Club logo

Comments (9)

svendecabooter avatar svendecabooter commented on July 3, 2024

This calls a method on ContentEntityBase that is available in 8.1.x, but not in 8.0.x.
I'm trying to figure out what the recommended way is to support both branches.

from field_encrypt.

svendecabooter avatar svendecabooter commented on July 3, 2024

Feedback from swentel & bojanz on IRC:

  • To solve this properly, we'd have to make 2 branches (field_encrypt-8.0.x and field_encrypt-8.1.x), with appropriate code in each --> i.e. the 8.0.x branch would not call the parent, but implement that logic itself.
  • There is a core issue for trying to introduce compatibility checks: https://www.drupal.org/node/2656994
  • However: both of them agree not to bother with 8.0.x at this point, since it has only 1 month of life left anyway, before 8.1.x gets released.

from field_encrypt.

svendecabooter avatar svendecabooter commented on July 3, 2024

@nerdstein: do you have an opinion about this, regarding release strategy?
@TravisCarden: is it possible to work with the 8.1.x branch for your project?

from field_encrypt.

TravisCarden avatar TravisCarden commented on July 3, 2024

Thank you, @svendecabooter. We actually are using the 8.1.x branch for our project. I just happened across this bug and reported it as a courtesy. (I probably should've said so.) As far as I'm concerned you can close this issue "won't fix". Thanks!

from field_encrypt.

nerdstein avatar nerdstein commented on July 3, 2024

I think we should log this incompatibility within the readme for now but eventually fix it. Bear in mind, not everyone in the world is using the bleeding edge. I could see this being a major usability issue due to a lack of a functional 8.0.x version, so I think we need to fix it (eventually).

from field_encrypt.

svendecabooter avatar svendecabooter commented on July 3, 2024

OK.
Once we moved to drupal.org and created a 8.1.x branch / release, we can branch a 8.0.x off of that and provide a fix for 8.0.x, which shouldn't be too hard.

We would then have to keep the 2 versions in mind going forward though, and apply patches to both of them.

from field_encrypt.

nerdstein avatar nerdstein commented on July 3, 2024

We could create the branches here first, if time permits

from field_encrypt.

dawehner avatar dawehner commented on July 3, 2024

At this point in time there is IMHO no reason to support core 8.0.x. It doesn't retrieve security support either.

from field_encrypt.

nerdstein avatar nerdstein commented on July 3, 2024

Closing

from field_encrypt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.