Type conversion builtin functions to take default values about tengo HOT 4 CLOSED

I've been messing around a bit trying to understand the code, so i tried messing around with the type conversion default.

This is basically a proof of concept, would something like this work for you? if so i'll make a pr for all built in conversion types including tests.

If needed i can also add an error type ErrWrongObjectType or something like that when the default isn't an Int (for this specific case)

func builtinInt(args ...Object) (Object, error) {
	argsLen := len(args)
	if !(argsLen == 1 || argsLen == 2) {
		return nil, ErrWrongNumArguments
	}

	switch arg := args[0].(type) {
	case *Int:
		return arg, nil
	case *Float:
		return &Int{Value: int64(arg.Value)}, nil
	case *Char:
		return &Int{Value: int64(arg.Value)}, nil
	case *Bool:
		if arg.Value {
			return &Int{Value: 1}, nil
		}
		return &Int{Value: 0}, nil
	case *String:
		n, err := strconv.ParseInt(arg.Value, 10, 64)
		if err == nil {
			return &Int{Value: n}, nil
		}
	}

	if argsLen == 2 {
		switch arg := args[1].(type) {
		case *Int:
			return arg, nil
		}
	}

	return UndefinedValue, nil
}

from tengo.

Yeah, I'd appreciate if you could create a PR for this! 😄 Btw, I just merged a big PR that has some code changes around these type conversions. But it shouldn't be too different.

from tengo.

I also added a documentation on types: https://github.com/d5/tengo/wiki/Variable-Types. Just FYI.

from tengo.

I will create a PR shortly, should be able to adjust it to the changes you made in the latest PR in like an an hour or so

from tengo.