Giter Club home page Giter Club logo

Comments (8)

d4l3k avatar d4l3k commented on July 29, 2024

When you say cannot find package "foo", is the package name literally foo? Or is that just a placeholder?

That looks like an issue with how go-pry looks for pry.Pry() statements. It doesn't follow dependencies, just parses all go files recursively. With lots of vendor packages, that runs into issues if there's invalid go code.

from go-pry.

komuw avatar komuw commented on July 29, 2024

from go-pry.

d4l3k avatar d4l3k commented on July 29, 2024

You import docker which gets added to the vendor folder and docker is importing foo. It's probably from test code that would normally never run. I think the fix is to add a check to go-pry to not explore the vendor folder.

from go-pry.

komuw avatar komuw commented on July 29, 2024

merging #45 was probably a good move.

However, it now means that you cant use go-pry in a project where you are depending on dependencies that are in your vendor directory.

so I guess it is a tradeoff

from go-pry.

d4l3k avatar d4l3k commented on July 29, 2024

Like, you can't insert pry.Pry() statements in the vendored dependencies? Yeah, hmm... That's kind of the same issue as #19.

from go-pry.

komuw avatar komuw commented on July 29, 2024

no, I meant you cant insert pry.Pry() statements in your main package if that package main depends on dependencies in your vendor directory

from go-pry.

d4l3k avatar d4l3k commented on July 29, 2024

I just tested it and it seems to work just fine. That change just makes it so it doesn't look for pry.Pry() statements in the vendor folder. You can still import vendored dependencies.

from go-pry.

komuw avatar komuw commented on July 29, 2024

ok, cool. my bad

from go-pry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.