Giter Club home page Giter Club logo

Comments (3)

ffigueroal avatar ffigueroal commented on July 20, 2024

@davelandry Looking on this bug I found that || bottom condition on suggested code line was the one causing this issue.
Removing it and keeping only const position = this._colorScalePosition.bind(this)(this.config()); seems to be the solution.
In this example i set colorScalePosition = false; as default value and then from top to right counter clockwise returning to false.

geomap-colorScalePosition

I also have a question related to colorScalePosition = undefined behavior. If i set it as default value i got a non colored map as the next image. I don't know if it is related with this issue or is the expected behavior.
image

from d3plus-viz.

ffigueroal avatar ffigueroal commented on July 20, 2024

I also tested if you don't define a colorScalePosition which i think is defined by the following code.

_this18._colorScalePosition = function () {
    return _this18._width > _this18._height ? "right" : "bottom";
};

geomap-resize-colorscaleposition

Here i setted height = 400 and width = 1520 as default behavior and then changed to width = 300 and you can see how color scale changes its position.

from d3plus-viz.

davelandry avatar davelandry commented on July 20, 2024

Great analysis and testing @ffigueroal 🍻

I left some comments in the PR

from d3plus-viz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.