Giter Club home page Giter Club logo

Comments (5)

d3cod3 avatar d3cod3 commented on July 28, 2024 1

Yes, what's happening is normal, i'll explain:

in OSX ( and only there ) the MosaicRepo/bin/data/ folder content is the reference of what needs to be copied inside the bundle after compiling ( manually, and just for the first time, as newer compiles on the same path will maintain the bundle content ). It is working like that because until now, most of the time users in OSX just download the release and run it, so no issues with that, but yes, you're right, this need some kind of automation, i'll write a script to run after ( or before ) compile to automatically copy everything inside the bundle, so this scenario will disappear.

But yes, the idea of implementing a datafolder-available-check it's a good one, so let me know when you have it, and thanks for the suggestion!

This is the Mosaic bundle content ( for reference )

Sin título
:

with data/ content copied inside Resources/ folder and examples/ and plugins/ folders copied as it is.

sorry for the delay, i was AFK

from mosaic.

Daandelange avatar Daandelange commented on July 28, 2024

Ok, thanks for your clarification.
I think the Release should be as easy to run as a binary compiled from source (except it takes longer); so yes, please make this scenario disappear πŸ˜‡ .

https://github.com/d3cod3/Mosaic/tree/fix-dataFolder-issue-46
I got something here for checking the data folder and added some log messages to them. (Note: I also re-arranged some conditions to prevent duplicate code.)
There's even a fallback for grabbing it from the CompiledBinary/../data folder (which exists if ran from a MosaicRepos), but it looks at binary/../data so this might be insecure if the ReleaseBinary/../data exists in some rare cases. (possible solution: only include that part in debug builds, or strip it out)

from mosaic.

Daandelange avatar Daandelange commented on July 28, 2024

I'm looking into this, it has never been fixed and it really bothers me on every version increment.
Is there something like a "release" or "git" compile flag in Mosaic ? (not debug/release)

from mosaic.

Daandelange avatar Daandelange commented on July 28, 2024

That fixes them on OSX :)

from mosaic.

Daandelange avatar Daandelange commented on July 28, 2024

Closing this as it's been merged. :)

from mosaic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.