Comments (6)
I’ve reduced the test case down to four points that reliably reproduce the error. If I nudge any one of the points by a tiny amount, I’m able to compute the diagram successfully:
The failure is probably because there are collinear or cocircular points. Such a configuration of points has multiple valid Delaunay triangulations, as described in d3/d3#1895. This has been a problem in the past (see gorhill/Javascript-Voronoi#12). It was partially fixed by updating the port (d3/d3#1538), but I’m pretty sure we still don’t handle cocircular points correctly. As @jasondavies says, “I think a reasonable fix is to pick an arbitrary Delaunay triangulation in this situation.” But it’ll be some work to figure out how to implement that suggestion.
There was a pull request a while back that’s related (d3/d3#2238). But I haven’t had time to investigate it in detail and see if that’s an appropriate fix. I’ll try to look now.
from d3-voronoi.
Yeah, that fix just replaces the crash with an infinite loop, which is worse. 😁
from d3-voronoi.
Oops, I found something obviously wrong, and fixing it fixed this bug. I’m also testing some other changes which might make the code more reliable, but at least for your example, the above commit solves the problem.
from d3-voronoi.
from d3-voronoi.
Excellent! thanks for looking into it
from d3-voronoi.
Fixed in 0.3.3.
from d3-voronoi.
Related Issues (20)
- New examples for 1.0.1 HOT 4
- Crash in voronoi.triangles? HOT 4
- Handle collinear (and cocircular) points? HOT 5
- Suggestion: small optimization by returning the tangent instead of the angle HOT 1
- Cannot read property '0' of null in clipCells() HOT 13
- Voronoi.find(x,y) HOT 5
- polygons() returning [null, null, null] HOT 4
- .find() throws exception when data contains two elements on the same same position
- Missing Triangle? HOT 2
- Inverse Voronoi? HOT 1
- TypeError: Cannot read property 'circle' of null HOT 6
- Feature request; polygon extent HOT 2
- d3.voronoi mutates data HOT 3
- voronoi.findAll(x,y,r) HOT 2
- voronoi.polygons crashes (runs out of memory) HOT 2
- Relation with d3-delaunay HOT 1
- Cell.js:75 Uncaught TypeError: Cannot read property '0' of null HOT 2
- voronoi.polygons will run out of memory or return incorrect polygons for certain data sets. HOT 1
- Incremental Voronoi?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from d3-voronoi.