Comments (5)
This seems even better, where the range is always computed in integers, and then the step is applied:
function ticks(start, stop, count) {
var step = tickIncrement(start, stop, count);
return step >= 0 ? range(
Math.ceil(start / step) * step,
Math.floor(stop / step) * step + step / 2, // inclusive
step
) : range(
Math.floor(start * step),
(2 * Math.ceil(stop * step) - 1) / 2, // inclusive
-1
).map(x => x / step);
}
Results in: [5.8, 5.85, 5.9, 5.95, 6, 6.05, 6.1, 6.15, 6.2]!
from d3-array.
Actually, it may not be necessary to deprecate or change d3.tickStep. I believe (but need to verify using a simple for loop) that in any case that d3.tickStep returns a step where |step| < 1, that 1 / step will be an integer. Even if that’s not the case, we could always Math.round it.
That means that the only real change will be in code that rounds according to the tick step. So nice could look like this:
var step = tickStep(start, stop, count);
if (Math.abs(step) >= 1) {
start = Math.floor(start / step) * step;
stop = Math.ceil(stop / step) * step;
} else {
step = 1 / step;
start = Math.floor(start * step) / step;
stop = Math.ceil(stop * step) / step;
}
And ticks could look like this (note: abusing the count argument as a temporary):
function ticks(start, stop, count) {
var step = tickStep(start, stop, count);
return Math.abs(step) >= 1 ? range(
Math.ceil(start / step) * step,
Math.floor(stop / step) * step + step / 2, // inclusive
step
) : count = 1 / step, range(
Math.ceil(start * count) / count,
(2 * Math.floor(stop * count) + 1) / (2 * count), // inclusive
step
);
}
Which has the same behavior on the OP’s test case.
from d3-array.
Slightly cleaner?
function ticks(start, stop, count) {
var step = tickStep(start, stop, count);
if (Math.abs(step) >= 1) {
start = Math.ceil(start / step) * step;
stop = (2 * Math.floor(stop / step) + 1) * step / 2; // inclusive
} else {
count = 1 / step;
start = Math.ceil(start * count) / count;
stop = (2 * Math.floor(stop * count) + 1) / (2 * count); // inclusive
}
return range(start, stop, step);
}
from d3-array.
Guess I’m wrong—we can’t assume that 1 / step will be an integer, at least for extreme values. We probably will need a tickIncrement method, then.
https://runkit.com/57d8702e1ff21014007f12d5/58138606783f93001320ab74
from d3-array.
@mbostock Hats off, this is a very elegant solution for the task at hand (stumbled upon this while looking for the reason for having both tickStep
and tickIncrement
).
from d3-array.
Related Issues (20)
- BUG: d3-array/dist/d3-array.js: Unexpected token (139:15) HOT 4
- fix(babel): cumsum HOT 1
- binary ticks increments on linear scale HOT 2
- D3-array produces ERR_REQUIRE_ESM with node >= 15 HOT 3
- bisectCenter naming HOT 1
- quantile returns undefined on an empty array, differs from extent HOT 1
- Docs: define the bin thresholds with array HOT 2
- First and last thresholds are set to data extent (not explicitly stated limits) HOT 2
- bisector no longer supports two-argument (object, value) comparator HOT 12
- Testing a lib using `d3-array` HOT 1
- d3.blur HOT 1
- Incorrect results for binary search on large arrays due to miscomputation of midpoint HOT 11
- d3.bin can mutate the user-specified thresholds
- About the sorting problem of d3.rank HOT 2
- Insecure Randomness for the useof Math.random() in shuffle API (security vulnerability) HOT 1
- d3.thresholdScott returns NaN for single-element arrays
- Feature request: `find` / `findValue` methods
- groupSort should use ascendingDefined instead of ascending
- medianIndex/quantileIndex doesn’t handle missing data HOT 3
- can d3-array also support BigInt numbers? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from d3-array.