Giter Club home page Giter Club logo

Comments (4)

CzBiX avatar CzBiX commented on August 24, 2024

When progress greater than 50%, it will show as white color (in light theme).
It should always be white in dark theme.

from qb-web.

bacon-cheeseburger avatar bacon-cheeseburger commented on August 24, 2024

Honestly, I think there's too much going on with the progress bars. I don't think the text color needs to change based on finished %. The text already tells me exactly how much is finished, changing the color doesn't help or add anything. And then only doing this light mode makes it inconsistent with dark mode where it should always be white. Please consider just making the % text only white in both modes!

Even changing the color of the progress bar isn't really necessary, there's a label next to it that tells the status (downloading/uploading/paused). There's also upload and download speed columns so there's plenty of indicators to know what's going on..

from qb-web.

CzBiX avatar CzBiX commented on August 24, 2024

This text color is not meant to indicate the status of the download progress.
When progress less than 50%, the progress value in white color is not obvious on a gray background, so I set it to black.

The different progress colors are used to quickly find active items in the list.

And yes, closed issue will also receive notifications.

from qb-web.

bacon-cheeseburger avatar bacon-cheeseburger commented on August 24, 2024

This text color is not meant to indicate the status of the download progress.
When progress less than 50%, the progress value in white color is not obvious on a gray background, so I set it to black.

I think this is a case of solving a non-existent problem. I can see the logic in the progress bar color but I don't see any advantage to changing the % text color at >=50%. There's nothing special about 50% and it breaks consistency with dark mode behavior. I guess we just have to agree to disagree on this one, which is ok.

from qb-web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.