Comments (1)
11 maj 2016 kl. 00:08 skrev Brendan McCollam <[email protected]mailto:[email protected]>:
Obviously brevity is frequently a virtue in programming, but as an outsider trying to grok this codebase, I am finding the prevalence of opaque two- and three-letter variable names to be a significant obstacle.
Some selected examples include acrhttps://github.com/rohe/pyoidc/blob/master/src/oic/utils/authn/authn_context.py#L47, achttps://github.com/rohe/pyoidc/blob/master/oidc_example/op2/server.py#L408, cdbhttps://github.com/rohe/pyoidc/blob/master/oidc_example/op2/server.py#L398, and OAShttps://github.com/rohe/pyoidc/blob/master/oidc_example/op2/server.py#L549. Of course I can go and track down where each terse variable is defined and figure out what they are, but especially in the examples folder, it would be much easier for newcomers to get their bearings if the variable names were long and explicit, and gave the reader some notion of what they are at a glance.
Good advice, I’ll take it to heart !
— Roland
from pyoidc.
Related Issues (20)
- Document release process / pypi upload HOT 2
- Create python 3.11 compatible release for pypi HOT 2
- Client.request_and_return no longer works with NoneResponse HOT 5
- Update conda-forge packages HOT 1
- Update URL references after repo move HOT 2
- AttributeError: 'dict' object has no attribute 'create_cookie' HOT 3
- Allow using different authn_method in Consumer.complete()
- Consumer.backchannel_logout and handling state HOT 11
- Architecture question regardings multiple app instances HOT 3
- Cannot add `scope` to registration request HOT 5
- Release 1.5.1 HOT 4
- Investigate failing readthedocs.io build HOT 1
- pydantic 2 seems to be incompatible with oic currently HOT 1
- Now in seconds vs. milliseconds: IATError: Issued in the future HOT 2
- Multiple matching kid support HOT 1
- Add support for RFC 9207 (?) HOT 1
- Why does `Client.do_access_token_refresh` require `state`? HOT 2
- Use SLSA workflow to create releases for PyPi HOT 1
- Client.parse_response misinterprets success as failure HOT 4
- Fix mypy
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyoidc.