__stdcall define wrong for Windows platform about cython HOT 7 CLOSED

@robertwb commented

I'm not quite sure I understand--if MS_WINDOWS is defined, then isn't __stdcall defined as well?

from cython.

JimKleckner changed summary from

!__stdcall define wrong for Windows platform

to

__stdcall define wrong for Windows platform
commented

Correct.

That is why the stub for !__stdcall is protected by an
#ifndef MS_WINDOWS
so that it won't blow it away in that case.

The issue is that Python.h doesn't include <windows.h> so that
when the conditions are processed, !__stdcall will not yet
be defined. In that case, we need to protect it with the platform
define.

In the DllMain embedding I'm playing with, I explicitly include
windows.h which then causes it to become defined. Without the
protection of MS_WINDOWS, it has already been made into an empty
string value.

from cython.

JimKleckner commented

I just spent a couple of hours tracking down a linkage problem after updating my tool chain because I forgot about this patch that never got applied.

One can argue that this is major if you are trying to build something on Windoze because linkage fails.

Please either apply the patch or tell my why you won't.

from cython.

JimKleckner commented

Attached is an updated patch that also defines _USE_MATH_DEFINES so that
M_PI and such will get defined as with the standard math.h.

from cython.

@robertwb changed priority from minor to critical
commented

from cython.

@robertwb changed resolution to fixed
status from new to closed
commented

Sorry it has taken so long, I don't have Windows to test this on, and no one has stepped up to do the same. (Also, it was marked as "minor" so it slipped under the radar for a while.)

Thank you for the patch, it's in now.

from cython.

@robertwb changed milestone to 0.9.8.1
commented

from cython.