Giter Club home page Giter Club logo

Comments (7)

jennifer-shehane avatar jennifer-shehane commented on June 2, 2024 1

@MikeMcC399 We used to have issues where users would click 'Rerun jobs' in GitHub Actions and the run would look like it's recording and running, but it essentially just exits 0 and looks like the tests passed, but they didn't run at all. That was because a new unique ci-build-id wasn't generated for each rerun.

If you're not seeing this behavior anymore (that all tests rerun in all situations of rerunning in github-action) then this may have been addressed on the Cloud side. I know they did do some work around better detecting unique identifiers of reruns.

If you're seeing the correct behavior on reruns, we can just remove the entire warning section.

from github-action.

MikeMcC399 avatar MikeMcC399 commented on June 2, 2024

I'm not sure if I have enough information to rework the warning, since it describes in part how Cypress Cloud works and this is not open source, so I would be limited to reverse engineering, which is not the ideal basis to provide definitive documentation.

The first step would be in any case for the Cypress (Cloud) team to review this part of the documentation.

from github-action.

MikeMcC399 avatar MikeMcC399 commented on June 2, 2024

@ryanpei Are you still involved in this area, and if so, could you comment?

from github-action.

ryanpei avatar ryanpei commented on June 2, 2024

Thanks @MikeMcC399 , I will try to find someone on our side who knows the exact behavior here. I'm not sure if "Re-run jobs" (as opposed to just the failed jobs, specifically) would re-run only on the containers which had failed. But otherwise this sounds right.

from github-action.

ryanpei avatar ryanpei commented on June 2, 2024

Yes, @MikeMcC399 's suggested edits are correct

from github-action.

MikeMcC399 avatar MikeMcC399 commented on June 2, 2024

@ryanpei

Thanks for your confirmation! Unfortunately since I haven't really understood the original warning text I have great difficulty in revising it sensibly, so I'm not able to resolve this issue on my own.

from github-action.

MikeMcC399 avatar MikeMcC399 commented on June 2, 2024

@jennifer-shehane

  • Thanks for your feedback! I have not seen any evidence of the problem you describe still being in existence so I have gone ahead and submitted a PR #1113 which removes the warning section and replaces it with advice about avoiding "Re-run jobs" > "Re-run failed jobs". It also adds a reference to Cloud options:

  • Spec Prioritization

  • Auto Cancellation

Note that

is still open.

from github-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.