Giter Club home page Giter Club logo

Comments (15)

sodatea avatar sodatea commented on June 9, 2024

The fixed webpack version also caused issues with HMR in Vue CLI 3.

from cypress-webpack-preprocessor.

chrisbreiding avatar chrisbreiding commented on June 9, 2024

This is fixed in 4.0.0, where the dependencies have been re-hatted and made into peer dependencies, so this packages will use the ones you already have installed.

from cypress-webpack-preprocessor.

dchambers avatar dchambers commented on June 9, 2024

Thanks so much @chrisbreiding 👍

from cypress-webpack-preprocessor.

dgreene1 avatar dgreene1 commented on June 9, 2024

This issue is reoccurring due to babel-loader having been added back in as a dev dependency (see the commit here). @chrisbreiding, can we reoppen the issue?

from cypress-webpack-preprocessor.

ghkich avatar ghkich commented on June 9, 2024

Im having the same problem. @chrisbreiding

from cypress-webpack-preprocessor.

DotCoyote avatar DotCoyote commented on June 9, 2024

Same, please reopen!

from cypress-webpack-preprocessor.

chrisbreiding avatar chrisbreiding commented on June 9, 2024

I tried this out with a fresh create-react-app and @cypress/webpack-preprocessor install and couldn't reproduce this issue.

It doesn't seem like it should happen since the only production dependencies this package has are bluebird and debug, so any babel-related dependencies don't get installed with it.

For folks experiencing this issue, can you verify you don't have babel or babel-* dependencies in your own package.json? Or can you try removing @cypress/webpack-processor as a dependency of your project and verify this error doesn't still occur?

from cypress-webpack-preprocessor.

DotCoyote avatar DotCoyote commented on June 9, 2024

This is my package.json (without @cypress/webpack-processor now, it's an ionic-project):

{
  "name": "",
  "description": "",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "cypress:open": "cypress open -p 4000 --config baseUrl=http://localhost:3000",
    "start": "react-scripts start",
    "build": "react-scripts build",
    "dev": "npm run start",
    "test": "react-scripts test",
    "test:ac": "cypress run",
    "lint": "eslint --fix --ext .js,.jsx,.ts,.tsx .",
    "eject": "react-scripts eject",
    "android": "ionic build && ionic capacitor update android && ionic capacitor copy android",
    "ios": "ionic build && ionic capacitor update ios && ionic capacitor copy ios"
  },
  "dependencies": {
    "@capacitor/android": "^1.5.0",
    "@capacitor/core": "^1.5.0",
    "@capacitor/ios": "^1.5.0",
    "@ionic/pwa-elements": "^1.4.1",
    "@ionic/react": "^5.0.0",
    "@ionic/react-router": "^5.0.0",
    "ionicons": "^5.0.0",
    "ipfs-http-client": "^40.1.0",
    "jdenticon": "^2.2.0",
    "ky": "^0.18.0",
    "ky-universal": "^0.5.0",
    "multihashes": "^0.4.15",
    "prop-types": "^15.7.2",
    "react": "^16.10.2",
    "react-dom": "^16.10.2",
    "react-redux": "^7.1.3",
    "react-router": "^5.1.0",
    "react-router-dom": "^5.1.0",
    "redux": "^4.0.5",
    "redux-devtools-extension": "^2.13.8",
    "web3": "^1.2.6",
    "web3-core": "^1.2.6",
    "web3-eth": "^1.2.6",
    "web3-eth-contract": "^1.2.6",
    "web3-utils": "^1.2.6"
  },
  "devDependencies": {
    "@capacitor/cli": "^1.3.0",
    "@ionic/cli": "^6.1.0",
    "@testing-library/react": "^9.4.1",
    "@types/enzyme": "^3.10.5",
    "@types/enzyme-adapter-react-16": "^1.0.6",
    "@types/jest": "^24.0.18",
    "@types/node": "^12.7.12",
    "@types/react": "^16.9.5",
    "@types/react-dom": "^16.9.1",
    "@types/react-redux": "^7.1.7",
    "@types/react-router": "^5.1.1",
    "@types/react-router-dom": "^5.1.0",
    "@types/react-test-renderer": "^16.9.2",
    "assert": "^2.0.0",
    "crypto-browserify": "^3.12.0",
    "cypress": "^4.2.0",
    "enzyme": "^3.11.0",
    "enzyme-adapter-react-16": "^1.15.2",
    "eslint": "^6.8.0",
    "eslint-config-airbnb": "^18.0.1",
    "eslint-import-resolver-typescript": "^2.0.0",
    "events": "^3.0.0",
    "node-sass": "^4.13.1",
    "react-scripts": "^3.2.0",
    "react-test-renderer": "^16.12.0",
    "stream-browserify": "^2.0.2",
    "typescript": "^3.6.3"
  }
}

from cypress-webpack-preprocessor.

chrisbreiding avatar chrisbreiding commented on June 9, 2024

@DotCoyote Does the issue not occur with @cypress/webpack-preprocessor removed?

from cypress-webpack-preprocessor.

DotCoyote avatar DotCoyote commented on June 9, 2024

No, works perfectly fine without @cypress/webpack-preprocessor

from cypress-webpack-preprocessor.

chrisbreiding avatar chrisbreiding commented on June 9, 2024

What's the output of npm ls babel-loader?

from cypress-webpack-preprocessor.

DotCoyote avatar DotCoyote commented on June 9, 2024

Without @cypress/webpack-preprocessor:

[email protected] /Users/dddd/Documents/app
└─┬ [email protected]
  └── [email protected] 

With @cypress/webpack-preprocessor:

[email protected] /Users/dddd/Documents/app
├─┬ @cypress/[email protected]
│ └── [email protected] 
└─┬ [email protected]
  └── [email protected] 

But I now saw the error only came up, once i installed webpack typescript ts-loader additionally to @cypress/webpack-preprocessor

i followed this tutorial: https://glebbahmutov.com/blog/use-typescript-with-cypress/

from cypress-webpack-preprocessor.

chrisbreiding avatar chrisbreiding commented on June 9, 2024

I'm seeing now that optionalDependencies get moved into dependencies when a package is published. It's not intended for them to get installed with this package, so I guess I'll have to move them to peerDependencies.

from cypress-webpack-preprocessor.

chrisbreiding avatar chrisbreiding commented on June 9, 2024

Thanks for the information, @DotCoyote. It was very helpful. I'll get a new version out soon.

from cypress-webpack-preprocessor.

chrisbreiding avatar chrisbreiding commented on June 9, 2024

The fix for this was mistakenly published in 4.1.4, but it should have been a major version because it is a breaking change.

It has now been properly republished in 5.0.0.

🎉 This issue has been resolved in version 4.1.4 🎉

The release is available on:
- npm package (@latest dist-tag)
- GitHub release

Your semantic-release bot 📦🚀

from cypress-webpack-preprocessor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.