Giter Club home page Giter Club logo

Comments (3)

cblgh avatar cblgh commented on July 30, 2024

i went ahead and made a pr #135 with the suggestions above, feel free to do close/merge/whatever!

from cypress-example-kitchensink.

jennifer-shehane avatar jennifer-shehane commented on July 30, 2024

@cblgh Thanks for the suggestion! This isn't the first time we have gotten it.

This repo serves 2 purposes which makes this change a little bit more work.

  1. It's a great repo to fork and get running yourself to play around with (as you have done).
  2. It serves as the scaffolding for the example project that Cypress seeds in every new project.

The suggestion you made works great for #1, but requires some changes to accommodate #2.

For #2, we do not include a cypress.json file in new projects. We also replace all of the urls with https://example.cypress.io so that they don't require any server to be running, so just including the baseUrl in the cypress.json file is not a solution.

We do already have a script written that transforms the localhost url to example.cypress.io url, so it is likely possible that we could also update the script to handle the url's missing the localhost url (since it's included in the cypress.json).

The cypress repo is open source, so if you could update the conversion script to handle this, we'd be glad to merge the changes in - otherwise, this is a low priority issue on our side that we likely will not have time to spend on.

from cypress-example-kitchensink.

cblgh avatar cblgh commented on July 30, 2024

alright, in that case i'll go ahead and close it :)

from cypress-example-kitchensink.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.