Giter Club home page Giter Club logo

Comments (18)

fnxweb avatar fnxweb commented on May 23, 2024 1

Bug still present in 0.73.1.5 I'm afraid.

from kitty.

cyd01 avatar cyd01 commented on May 23, 2024 1

from kitty.

lars18th avatar lars18th commented on May 23, 2024

Hi,

I confirm that this bug continues.

Try this @cyd01 please:

  • kitty.exe -title TEST ...

Then the NAME of the Window will be for example the path of the shell. After that you can minimize the window. And after you can reopen the window, but then you'll see that the TITLE NAME is now "TEST" instead of the previous one.

I hope you can fix it.
Regards.

from kitty.

lars18th avatar lars18th commented on May 23, 2024

Please @fnxweb check last version. I feel this bug is solved.

from kitty.

lars18th avatar lars18th commented on May 23, 2024

Hi @cyd01 ,

Tested with the last version 0.73.2.3: If I execute kitty.exe -title TEST ... then the word "TEST" appears in the Title Window. All OK. And I can minimize and restore, and it works.

However, if after that I execute kitty.exe ... (that's without changing the title with the parameter -title) then continues to appear the word "TEST" in the title. I feel something is stored from the previous session.

Please, check it. Other than that, I think the problem is solved.
Regards.

from kitty.

cyd01 avatar cyd01 commented on May 23, 2024

I did not reproduced. I've checked the code (search for -title in window.c).

		} else if( !strcmp(p, "-title") ) {
			i++ ;
			conf_set_str( conf, CONF_wintitle, argv[i] );

The is no reason for the specified title is stored ... are you sure you did not save the session before running it (check Window\Behavior panel) ?

from kitty.

lars18th avatar lars18th commented on May 23, 2024

I did not reproduced. I've checked the code (search for -title in window.c).

		} else if( !strcmp(p, "-title") ) {
			i++ ;
			conf_set_str( conf, CONF_wintitle, argv[i] );

The is no reason for the specified title is stored ... are you sure you did not save the session before running it (check Window\Behavior panel) ?

No. I run it from the command line! 😨

from kitty.

fnxweb avatar fnxweb commented on May 23, 2024

The issue is still present in 0.73.2.3 I'm afraid.

  • Open a session — my login sets the title to the CWD immediately (“title 1”)
  • Minimise then un-minimise window : title is reset to “IP-address/host - KiTTY”
  • Set the title via the session / terminal escape sequences (“title 2”)
  • Open settings and just then close settings : “title 2” “stored”
  • Change title again (“title 3”)
  • Minimise then open again: title has reverted to “title 2”

from kitty.

lars18th avatar lars18th commented on May 23, 2024

Hi @fnxweb ,

I think the same, the problem is not fixed. Something is wrong in the logic of the windows's title.

Regards.

from kitty.

systemmonkey42 avatar systemmonkey42 commented on May 23, 2024

Hi @cyd01

The issue is still present in 0.73.2.4. (Portable, if that makes a difference).

Any attempt to resize the window will immediately reset the window title to the original title (either whatever is configured/saved in the config, or the default "HOST - KiTTY" title)

Regards

from kitty.

lars18th avatar lars18th commented on May 23, 2024

Hi @systemmonkey42 ,

Then it will clear that's a problem with the title management. I hope @cyd can fix it at some point.

Regards.

from kitty.

systemmonkey42 avatar systemmonkey42 commented on May 23, 2024

I think I've found the source of the problem.

Open kitty.ini and look for wintitle= in the KiTTY section.

Setting wintitle=no will keep remotely set titles

The default causes the remotely set title to be cleared every time the window size changes.

from kitty.

fnxweb avatar fnxweb commented on May 23, 2024

I don't think that'll help my use case, since I'm trying to keep my remotely set window titles, not disable them.

from kitty.

systemmonkey42 avatar systemmonkey42 commented on May 23, 2024

My wording is not the best. The default of wintitle=yes resets the remotely set title on every window size change.

Set it to no to allow remotely set title to stay set.

This does not disable remotely set titles.

from kitty.

fnxweb avatar fnxweb commented on May 23, 2024

Confirmed, thanks @systemmonkey42 — setting [KiTTY] / wintitle=no in a kitty.ini next to kitty.exe fixes/works around the problem.

I don't know what that setting is intended to do, it's not a mirror of the enable/disable-remote-window-titles setting in the GUI, so I don't know if there's another side effect.

from kitty.

lars18th avatar lars18th commented on May 23, 2024

Hi,

As defined here:

X(BOOL, NONE, no_remote_wintitle) /* disable remote retitling */ \

write_setting_b_forced(sesskey, "NoRemoteWinTitle", conf_get_bool(conf, CONF_no_remote_wintitle));

The [KiTTY] / wintitle=no entry is to disable all the title management. But as defined here it's too another config variable to enforce a title:
write_setting_s(sesskey, "WinTitle", conf_get_str(conf, CONF_wintitle));

Futhermore, if you check the code searching for "wintitle" your see lines like these:

if (!term->no_remote_wintitle)

sfree(dp->wintitle);

IMO, I feel the problem is related to an inconsistent processing of the title. I suspect that multiple actors are changing the title. Then some refactoring is required.

I hope it helps.
Regards.

from kitty.

lars18th avatar lars18th commented on May 23, 2024

Hi @cyd01 ,

Do you reviewed the code regarding the wintitle variable?

from kitty.

cyd01 avatar cyd01 commented on May 23, 2024

Title is controlled by window event of course ... but it is controlled by terminal too.
You must check disable remote-controlled window title changing in Terminal/Features configuration panel.

from kitty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.