1.4.x support about kerbalengineer HOT 13 OPEN

should be fixed here https://github.com/jrbudda/KerbalEngineer/releases

You'd think FindAttachNodeByPart would never return null for a part that is actually attached and AttachNode's can be of type SURFACE. But you'd be wrong.

from kerbalengineer.

https://github.com/jrbudda/KerbalEngineer/releases/tag/1.1.4.0

from kerbalengineer.

Please please please add 1.4.1 support when you have time! This is my favorite mod!

from kerbalengineer.

Besides the warning on game entry, it seems to work just fine. Have you experienced any problems?

from kerbalengineer.

I would really want this too and also better support for making history expansion! 🙂

from kerbalengineer.

Oh hey... you're right. It works perfectly. Well.. color me surprised.

Awesome!

from kerbalengineer.

Aha, it looks like you have taken over the development in your own fork? @jrbudda

from kerbalengineer.

I don't really want to 'take over' but thought I'd spend a couple hours getting something out there working for folks. I did submit a PR for the changes, but it looks like PRs havent been pulled here since October so I uploaded a release on my fork.

from kerbalengineer.

That is great and I wouldn’t say that taking over would be a bad thing since this repo is already pretty much dead but yeah 🙂 Great work though 👍

from kerbalengineer.

@jrbudda DUDE!! I love you! Thank you for this!! YOU ARE THE BEST!!

If he doesn't respond in some time -- think about maybe submitting this to CKAN so that others may benefit?

Thanks again!!

from kerbalengineer.

Thanks @jrbudda
Unfortunately, I found an issue with your update, if I attach RCS thrusters to an engine plate it throws:

[Exception 20:52:54.0799760]: SimManager.StartSimulation() // Object reference not set to an instance of an object
[]: at KerbalEngineer.VesselSimulator.PartSim.DecoupledInStage (.Part thePart) [0x00000] in :0
at KerbalEngineer.VesselSimulator.PartSim.New (.Part p, Int32 id, Double atmosphere, KerbalEngineer.LogMsg log) [0x00000] in :0
at KerbalEngineer.VesselSimulator.Simulation.PrepareSimulation (KerbalEngineer.LogMsg _log, System.Collections.Generic.List`1 parts, Double theGravity, Double theAtmosphere, Double theMach, Boolean dumpTree, Boolean vectoredThrust, Boolean fullThrust) [0x00000] in :0
at KerbalEngineer.VesselSimulator.SimManager.StartSimulation () [0x00000] in :0

from kerbalengineer.

Ah yea looks like anything surface-attach

from kerbalengineer.

Dude, you are awesome. Thanks for the quick turn-around on this.

As a fellow programmer, I can relate. Obvious API calls not doing the obvious. ;)

Ha ha -- good work though man. Thanks!!

from kerbalengineer.