Giter Club home page Giter Club logo

Comments (3)

cyanreg avatar cyanreg commented on May 30, 2024

It's a good idea, but patches welcome - I'm trying to get replaygain to work so I can release 1.0.
Would be nice to reuse that code to support config files too.

from cyanrip.

Lebon14 avatar Lebon14 commented on May 30, 2024

(JSON might be good for this)

I'd suggest a simple text file. I'm working on an example right now. I will post the example text files later.
The reason why I think a simple text file is better is because of the familiarity it brings. It's a .txt file, a simple double click and bam, text editor opens and ready to edit. I know that this ripper isn't for the mortals (until there's a GUI). Syntax is not needed, the program just knows how to parse the file and that can be auto-generated with a command.

from cyanrip.

Lebon14 avatar Lebon14 commented on May 30, 2024

Sorry for the delay! Two files: the example, followed by the explanations. That made me find some oversight in the features.
cyanrip ripping file example.txt
cyanrip ripping file explained.txt

The oversights:

  • The Drive Speed feature isn't detailed on how it works. Is it a percentage or what?
  • The Paranoia feature setting isn't explained either.
  • In output format, for AAC, there should be an option for the file to be in a m4a file instead of mp4. You might get away by changing the extension but most people are familiar for the audio to use m4a and video to be mp4.
  • As I understand, as of right now, the encoder only support CBR lossy files. VBR and ABR should be added. Since MP3 uses a different encoding setting for VBR, a new line was added to set a value between V0 and V9. The lossy mode should get its own command flag as well as MP3 VBR (if needed).
  • As of right now, filename sanitation is awkwardly worded. It defines two values but otherwise isn't really documented. I added the values "Windows", "Mac" and "Linux" to make it clear that the sanitation will take into consideration the OS entered. That said, "OS_UNICODE" should be removed; only simple remains as this will just remove any characters that can cause issues.
  • Art embedding: There could be four different options here. User provided file (EMBED_FILE), user provided url (EMBED_URL), automatic lookup (EMBED_QUERY) or no embed (boolean EMBED_ART).
  • The album metadata should be working roughly like described in the original documentation? Anyway, nothing goes into quotes because the user could use quotes as part of the album name. The "=" should be the start of the metadata and ":" on the next line the end (the first pace after the = should be ignored). Number of disc and tracks values are between quotes that means that they will take their value automatically from either the "MULTI_DISC" command or the number of tracks polled from the disc. You can delete them, it'll just override these automatic values.
  • Now, there could be more tags for tracks such as Composer or Performer but I went for the minimum. It works like the album meta. The "ALBUM" value between quotes will get the value from the "Album Artist" tag from the disc info. Overriding it is expected as it'll be used for compilations.

If any questions, just let me know here. I'll check here later.

from cyanrip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.