Comments (5)
Another use case is checking if the user is able to supply Rust feature gates (like #![feature(…)]
).
from autocfg.
Is there any particular reason why this is private?
It's a conservative API choice, not having to worry about how that function looks. Right now it takes T: AsRef<[u8]>
and returns Result
, which isn't necessarily something I'd want to lock into the API, but it doesn't matter when that's private. There's also a little bit of implicit "magic" for #![no_std]
that might have to be explained (and committed to) if we allow sending code directly to this context.
It would be nice to be able to check if
#[non_exhaustive] struct Foo
is supported without having to return a zero-sized type to make an expression.
You don't have to return Foo
-- a block expression works just as well returning the unit ()
implicitly:
ac.emit_expression_cfg("{ #[non_exhaustive] struct Foo; }", "supports_non_exhaustive");
Rustc will warn of dead code, that Foo
is never constructed, but all output is captured from build scripts anyway.
Another use case is checking if the user is able to supply Rust feature gates (like
#![feature(…)]
).
I think this might deserve a dedicated probe_feature
, but nobody has asked for it yet.
from autocfg.
Something like what anyhow does would probably also be best exposed via custom probes.
autocfg gets a lot of details right regarding how to invoke rustc (propagating rustc flags and --target
), but its fairly restricted API means there are many re-implementations of that logic throughout the ecosystem -- and most of them are buggy.
from autocfg.
Another issue that could have been prevented if other crates could use autocfg for their probes: yaahc/eyre#84
from autocfg.
Judging from rust-lang/cargo#11138, doing build probes correctly looks like it is actually going to become even more subtle than it already is. It would be really useful if that functionality could be exposed so it doesn't need to be duplicated everywhere.
from autocfg.
Related Issues (20)
- Doesn't work with custom Rust sysroot HOT 3
- rust-flags specified in cargo configs are ignored by autocfg. HOT 6
- Publish 1.0 HOT 7
- Probe const_fn HOT 3
- crate has single crates.io owner HOT 3
- Support RUSTC_WRAPPER HOT 2
- Probing for nightly HOT 3
- Is there some way to hide the rustc output? HOT 6
- Can I probe for const generics support? HOT 3
- autocfg does not work in the presence of -Z build-std HOT 8
- hanging on aarch64 HOT 3
- error: could not compile `autocfg` HOT 4
- Backport CARGO_ENCODED_RUSTFLAGS to version 0.1 HOT 2
- Consider adding `--cap-lints=warn` to probe `rustc` invocations
- 'probe' does not work under Miri HOT 3
- Not compiling in Docker image running on M1 Mac using `--platform linux/amd64` HOT 3
- Build errors on riscv64-linux HOT 2
- Program unexpected panic when unwrap is used HOT 1
- Fails to detect crate std on NixOS HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autocfg.