Giter Club home page Giter Club logo

Comments (11)

schnuffle avatar schnuffle commented on June 5, 2024 1

I slightly disagree,
I think the information to build a package should be contained in the repo. I'm not talking about binaries, only source files.
For me it sounds like not integrating make files into the source code because it will pollute the repo.

In the end it's exactly three files:

  • A control file to generate the package
  • A postinst script
  • A script to build the docker image, extracts the binaries for later usage and creates the package

Now let's assume we have 10 debian based distros and 10 redhat based distros, that would only make max 10 control files/postinst scripts + one build script and maybe the same for the RPM based distros.

From my experience it's really helpful to have everything needed to build a software contained in the repo.
But I don't have a problem with you disagreeing and will happily the keep the stuff in my repo fork.

If you're still interested in getting cutelyst packaged for debian, I can see if I can manage to create two packages.

Regards
Schnuffle

from virtlyst.

dantti avatar dantti commented on June 5, 2024

I'm fine if you provide a link to your GitHub repo (on the wiki) which can generate a package, but I'm against having packaging inside the repo, in my opnion this is a task for packagers and if all sorts of distro packages where included in the repo would become a mess.
I tried a while ago to get Cutelyst packaged for Debian but the guy gave up and I don't have much time to do this, but the best option IMO is having it packaged on the distro.

from virtlyst.

ev0lister avatar ev0lister commented on June 5, 2024

Appreciate the work for a debian package. I want to use Virtlyst as my homeserver KVM management and dont want to install the whole build environment / docker on it. A deb package is much more handy and comes with less overhead plus actually makes it usable for more people. Thanks!

from virtlyst.

schnuffle avatar schnuffle commented on June 5, 2024

I updated my debian package branch.
For the moment it only builds for ubuntu 18.04, haven't tested any other distro. Changes might be needed for the dependencies.
As I don't have a build service connected you'll still need to have a box to build the package.

from virtlyst.

ev0lister avatar ev0lister commented on June 5, 2024

Thanks. Indeed was building it on a debian stretch just now. The dependencies look strange from debian point of view. Edited the control file to the following dependencies: Depends: libqt5core5a, libqt5network5, libqt5sql5, libqt5xml5, libvirt0, libgrantlee-templates5 guess your dependencies are valid for ubuntu 18.04 only? After that, it just works fine.

from virtlyst.

schnuffle avatar schnuffle commented on June 5, 2024

Good to know, I'll add a parameter to the build script, so one is able to choose between ubuntu 18.04 and debian stretch

Have fun

Schnuffle

from virtlyst.

schnuffle avatar schnuffle commented on June 5, 2024

Are you sure that your deps are complete?
I guess that you are missing some deps but it works because you have them installed already.

from virtlyst.

ev0lister avatar ev0lister commented on June 5, 2024

I took them from Dockerfile for Virtlyst as provided in the second step where the runtime is build, so I guess, yes should be complete. Currently testing it on a clean debian and will reply back.

from virtlyst.

ev0lister avatar ev0lister commented on June 5, 2024

adduser: The group 'libvirt' does not exist. so I guess the postscript needs the full libvirt installed on this host. I wonder if its the intention to require a host with libvirt locally installed for virtlyst. Imagine a small VM managing KVM hosts. What do you think? Add libvirt-daemon-system libvirt-clients as dep?

from virtlyst.

schnuffle avatar schnuffle commented on June 5, 2024

That is reasonable
My need is mostly for running some VMs on root servers. I need a light weight interface to be able to do basic management and have access to the console.
If i stay with libvirt, I have the choice to use virt-manager, virsh or Virtlyst in parrallel, which is perfect for me.

So pulling in a working libvirt environment sounds correct for me.

I'll sort out which packages are needed for ubuntu and debian and add them to the deps.

from virtlyst.

dantti avatar dantti commented on June 5, 2024

PR is welcome, likely CPack is the easier option

from virtlyst.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.