Extract method `_calculateProductQuantity` in observer about customgento_configurabletierprices HOT 10 CLOSED

Thanks for your useful feedback. Indeed, the tagged version is quite old. I would accept a pull request with such a change. Afterwards, I would tag a new version. Mind that we switched the namespace from Spranks to CustomGento though.

from customgento_configurabletierprices.

Great, one pull request coming up! :)
We're aware of the changed namespace, btw...

from customgento_configurabletierprices.

@sprankhub

In the observer on line 58...

if ($item->getParentItem()) {
    continue;
}

Is that used to filter out non-configurable products?

If so, isn't that already covered by...

if (Mage::registry('current_product') || !$product->isConfigurable()) {
    return $this;
}

If not, please explain :)

from customgento_configurabletierprices.

It's been a while since I wrote this code :-)

Mind that we iterate over all visible quote items and then filter by $item->getParentItem(). This has nothing to do with the current product. Hence, I guess both filters make sense.

from customgento_configurabletierprices.

Correct, I realized that right after posting my comment :)

I'm still a bit confused, though.
I have one simple product and two configurable products (t-shirts - medium and large).
I would have expected that for the two t-shirts, $item->getParentItem() would return the parent configurable product, but then the code wouldn't work of course...

So I think my question is, what scenario is the if statement covering? Bundled products?

(Hope I'm making sense)

from customgento_configurabletierprices.

Mind that $item->getParentItem() returns a quote item and not a product. If you add a configurable product to the cart, there are two quote items - a parent and a child item. Simply add a configurable product to the cart and check the quote item table. This should make things a bit clearer.

from customgento_configurabletierprices.

Aha, makes sense, tnx!

from customgento_configurabletierprices.

Actually, checking for $item->getParentItem() is not necessary since you're using getAllVisibleItems()...

It's already being filtered out in Mage_Sales_Model_Quote...

public function getAllVisibleItems()
{
    $items = array();
    foreach ($this->getItemsCollection() as $item) {
        if (!$item->isDeleted() && !$item->getParentItemId()) {
            $items[] =  $item;
        }
    }
    return $items;
}

You agree?

from customgento_configurabletierprices.

I think you should be right :-)

from customgento_configurabletierprices.

This will be fixed with #34.

from customgento_configurabletierprices.