Giter Club home page Giter Club logo

Comments (3)

cursey avatar cursey commented on June 2, 2024

Time critical mods are just mods that need to be set prior to the game really doing anything important. So the Data Folder mod for example needs to be ran before the game actually loads any data (and to be fair it may be the only time critical mod). I don't load it concurrently with other mods because it needs to access m_mods from the Mods class. I could synchronize access to m_mods but I didn't realize my change would negatively affect anyone's loading. It doesn't cause my mabi to load/initialize forever. I can't think of why it would be doing that for you either. I guess I'll just synchronize it and see if that fixes your problem.

from kanan-new.

cursey avatar cursey commented on June 2, 2024

Please try the changes in 64598f9 and let me know if that helps.

from kanan-new.

kleric avatar kleric commented on June 2, 2024

Mabinogi still loads at the same speed, I just meant kanan initialization takes much longer, since we instead wait for the first frame to be rendered, rather than beginning mod initialization on injection.

I was thinking to just call loadCriticalTime mods at the beginning of load mods, but I think your change fixed it. Thanks!

from kanan-new.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.