Giter Club home page Giter Club logo

Comments (10)

bagder avatar bagder commented on May 17, 2024

I will agree that it would be useful to allow this to get extracted even when the check fails. You feel like taking a shot at a patch for that?

from curl.

Dunemaster avatar Dunemaster commented on May 17, 2024

Yes, I think I do. Any tips or guidance for this particular spot?

from curl.

bagder avatar bagder commented on May 17, 2024

Not really, i can't recall the exact reason why it ended up in that place within the handshake but a first try would be to just change where the call is made to instead be done before the certificate check is made.

from curl.

Dunemaster avatar Dunemaster commented on May 17, 2024

Ok, thanks, Should I also add a command line option (--showCertChain ) to the tool?

from curl.

bagder avatar bagder commented on May 17, 2024

That'd be great!

from curl.

Dunemaster avatar Dunemaster commented on May 17, 2024

Unfortunately, OpenSSL does not keep certificate chain info when verification fails (see ssl3_get_server_certificate in openssl). So implementing this feature is impossible without changes to openssl

from curl.

bagder avatar bagder commented on May 17, 2024

Ok, but isn't it possible to extract it before it fails then?

from curl.

Dunemaster avatar Dunemaster commented on May 17, 2024

No. Certificate chain is kept inside openssl and and never assigned to anything visible from outside.

from curl.

bagder avatar bagder commented on May 17, 2024

If you set CURLOPT_SSL_VERIFYPEER and CURLOPT_SSL_VERIFYHOST to 0 (like with --insecure) then you can still get the certs dumped without verification.

So what if we for example just stored the failed verification status and didn't react on it until after the certinfo is extracted?

from curl.

bagder avatar bagder commented on May 17, 2024

Dead

from curl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.