Giter Club home page Giter Club logo

Comments (4)

levicki avatar levicki commented on June 15, 2024

What I am trying to say is that either the version should have been bumped in the curlver.h as well, or the previous commit should have been amended and force-pushed so that version stays the same with fixed tarballs.

IMO current situation is confusing, because semantic version should apply to code changes, not to build artifacts and artifacts should match the code version, not have their own.

from curl.

bagder avatar bagder commented on June 15, 2024

Every curl release ever done has been shipped in a tarball. The contents of that tarball is the release.

A curl release is generated from the source code in git at a specific tag, which is named according to the release.

semantic version should apply to code changes

That's your opinion, not the one we use and stand for in the curl project.

This is not a curl bug. This is just your wrong assumptions.

from curl.

levicki avatar levicki commented on June 15, 2024

A curl release is generated from the source code in git at a specific tag, which is named according to the release.

Shouldn't the version in the git tag name and the version in the source match then? If not, why not?

That's your opinion, not the one we use and stand for in the curl project.

Not really my opinion, it's defined here : Semantic Versioning 2.0.0.

Or at least that's how I understand it, but of course my understanding may be incorrect or incomplete hence the request for clarification.

This is not a curl bug. This is just your wrong assumptions.

I never claimed it was a bug, but there's no "Question" issue template to request clarifications.

from curl.

bagder avatar bagder commented on June 15, 2024

Shouldn't the version in the git tag name and the version in the source match then? If not, why not?

It's a pointless exercise. Even if we would update the source to have the exact same version in the code as the tag, the contents in git does not match the release tarball because the release tarballs are generated. They contain files not present in git. Because we don't commit generated files.

That's your opinion, not the one we use and stand for in the curl project.

Not really my opinion, it's defined here : Semantic Versioning 2.0.0.

It does not say anything like that. We release "patch versions" when we fix the release. We fixed the 8.7.0 release so we made 8.7.1. We bumped the minor version number because it was a bugfix release. Exactly the way semver explains patch versions should work. Nowhere does it say that only a subset of bugfixes may be counted as bugfixes.

This is not a curl bug. This is just your wrong assumptions.

I never claimed it was a bug, but there's no "Question" issue template to request clarifications.

Yes there was. And since a few minutes back there are even two mentions on how to ask questions.

from curl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.