Cannot create FakeRedis with positional host & port arguments about fakeredis-py HOT 8 CLOSED

Hi, can you please post the full test code? I think you are using fakeredis incorrectly.
You should not override Redis, but create a connection using FakeRedis instead of Redis

See How to use section.

from fakeredis-py.

@cunla: I am using FakeRedis for unit tests. Since the code that creates the Redis connection is part of what's being tested, I'm using unittest.mock.patch() to replace the call to redis.Redis() with fakeredis.FakeRedis().

from fakeredis-py.

Can you post a sample test that fails here? I suspect (though not sure) you are patching in the wrong place.
Notice FakeRedis inherits from Redis so it might cause a circular dependency.

from fakeredis-py.

@macdjord ?

from fakeredis-py.

@cunla I can't give you the original code due to company policy. However, it looks something like this:

foo.py:

from redis import Redis

def connect_redis(redis_host: str, redis_port: int) -> Redis:
    redis_con = Redis(redis_host, redis_port)
    ...
    return redis_con

def bar(zip, zap):
    ...
    redis_con = connect_redis(redis_host, redis_port)
    ...

test_foo.py:

from unittest.mock import patch
from fakeredis import FakeRedis 
...
def test_bar():
    # Mock Redis connection
    with patch('foo.Redis', FakeRedis):
        # Call function
        bar(zip, zap)

        # Check the data in Redis is as expected
        ...

from fakeredis-py.

I use a very similar pattern (monkeypatch redis.Redis with FakeRedis for testing purposes) and can confirm this bug.

FakeRedis 1.7.1 works fine, anything after is broken.

OS: Debian Bullseye, CentOS 7
Python version: 3.9.2
redis-py version: 4.3.4
fakeredis version: 1.8.1

from fakeredis-py.

Trying today

from fakeredis-py.

Fix in 1.8.2

from fakeredis-py.