Giter Club home page Giter Club logo

Comments (3)

cunaedy avatar cunaedy commented on July 19, 2024

Hi,

  1. Unfortunately no. I want to avoid XSS. But in the future release, I may add MarkDown???
  2. I think you are correct. To fix the problem:

Remove the following line:

$item_sort_point = post_param('item_sort_point');

And replace the following line:

item_permalink = '$item_permalink', item_title = '$item_title', item_summary = '$item_summary', item_details = '$item_details', item_status = '$item_status', item_sort_point = '$item_sort_point', item_class = '$item_class',

To this line:

item_permalink = '$item_permalink', item_title = '$item_title', item_summary = '$item_summary', item_details = '$item_details', item_status = '$item_status', item_class = '$item_class',

from kemana-directory.

TavoVolfas avatar TavoVolfas commented on July 19, 2024

Thank you! I believe it fix the bug.

About HTML. Well people are used to know simple html tags like <b <img some formatting tags like color, size.
Of course it would be amazing to have description editor something like in reddit or here. (Allowed most important tags, and formating even from copy/paste text)

To prevent XSS maybe we could just ignore other tags except our "whitelisted"?
and/or just replace <script> to &lt;script&lt; everywhere in user input? I don't know much about XSS so i could be wrong.

PS. Why BB code is disabled and what made you to decide it (just curious) ?

from kemana-directory.

cunaedy avatar cunaedy commented on July 19, 2024

Hi,
Unfortunately, preventing XSS is not that easy, eg, you can still do XSS by using:

So, I think it's easier 😜 to remove the HTML support all together, except for backend.

About BBCode. I removed it because my implementation of BBCode was flawed.

In the future, I may re-add BBCode or MarkDown, or simply use plain text....?

from kemana-directory.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.