Giter Club home page Giter Club logo

Comments (7)

l3pp4rd avatar l3pp4rd commented on May 25, 2024

that would be great @CodeWriterDavid concerning JUnit formatter and a fix to outlines. I personally do not use outlines as it somehow reads harder and that may be the reason for having it incomplete.
What is your opinion about #13 returning errors in hooks?

from godog.

dasnook avatar dasnook commented on May 25, 2024

OK, great! I like outlines when there are a lot of similar examples, as it makes missing coverage much more obvious. But I certainly understand how you wouldn't have noticed this issue if you don't use them. :) Regarding the returning of errors in Before/After hooks, I like the idea of having them be like any other step (and also more idiomatic in terms of Golang's error-centric approach), but depending on how those errors are handled by the runner, it might not make much of a practical difference. Before/After are for setting up state, and if there is a failure there isn't much you can do but grind to a halt. It doesn't make sense to try to run any additional tests, as the state of the domain system is now unknown and unreliable. The one area it might make a difference would be reporting, if returning errors instead of panics would allow the runner to better report the current failure and wrap up the reporting of the tests run up to that point. On the other hand, panics are pretty telling with a stack trace. :)

from godog.

l3pp4rd avatar l3pp4rd commented on May 25, 2024

Yes, concerning errors on return, I agree, it does not make sense to try to continue running because these hooks are meant to manage/reset state. I think I'll keep it as is for now, until the obvious behavior pops in from context or someone proposes something to suit it better ;) thanks for the opinion

from godog.

l3pp4rd avatar l3pp4rd commented on May 25, 2024

hey @CodeWriterDavid maybe you could open a pull request with jUnit formatter and I'll hunt the bug?

from godog.

dasnook avatar dasnook commented on May 25, 2024

Hi, @l3pp4rd -- I already have a fix for the bug, I was just hoping to have a set of tests to go with it and it was taking me a bit to figure out how to best do that with the existing test setup. Very cool, by the way, how you use godog to test itself! If you don't need tests, I can have a pull request fairly soon.

from godog.

l3pp4rd avatar l3pp4rd commented on May 25, 2024

Ah great, thought that jUnit formatter can fade away if you are busy :) good to know you are still around, take your time ;)

from godog.

l3pp4rd avatar l3pp4rd commented on May 25, 2024

hi @dasnook I've merged your junit implementation and adapted it based on Behat junit output they have spent much time to find nicest way of formatting results. Also I have fixed the issue where background was not being printed together with scenario outline. cheers

just run godog -f junit > junit.xml

from godog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.