Comments (3)
Two extra thoughts on this:
- One way to do about the two-type solution would be that
bit
or something calledint
behaves in the "correct" way, whereasfixed<32, 0>
(i.e., a fixed-point number with no fractional bits) follows the "normal" rules above and is the right type for representing "content" data. - Just for reference, Mentor's ac_int uses the "correct" way. Their docs have a handy table showing how they calculate the bit widths for operations.
from dahlia.
I wonder why division is chosen to be W1 + W2
, instead of what I believe is the right answer, W1
. It mentions that &
is the way it is for consistency purposes with |
and ^
, so perhaps /
is the same way. Or, I'm missing something simple here.
from dahlia.
Just for fun: a new CIRCT thread refers to the same decision.
from dahlia.
Related Issues (20)
- Using fixed point in futil imports or function definitions doesn't work. HOT 3
- Fixed point division not using correct primitive. HOT 1
- Support reverse range iteration HOT 1
- Remove fixed point constants from Dahlia.
- Hoist slow binops incorrectly hoists
- Current Fixed Point Constant Implementation parses numbers incorrectly.
- Multi-cycle binary operations emit incorrect `write_en` guard.
- UnrollBank doesn't re-write same local variable names in different definitions.
- Add `@bound` attribute for loops with statically known bounds. HOT 1
- [Calyx] Don't generate conflicting assignments when lowering unrolled loops
- `split` views not lowered correctly
- [Calyx] Generate non-combinational reads for memories HOT 2
- Support for Constants and Dynamic Loops HOT 4
- Typechecker isSubtype does not handle alias type
- Typechecker Issue HOT 3
- Split views bypass typechecker and allow incorrect loop unrolling
- Parse error in let expression for bitwidth 32 and above
- Test has incorrect lowering HOT 3
- Parse issue for hexadecimal literals in cast expressions
- Issue in C++ backend when passing local array to function
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dahlia.