PPC64 server seems to be unable to handle player XYZ? about cuberite HOT 2 OPEN

This appears to be an issue with the 8 byte endian swapping functions in Endianness.h

https://github.com/cuberite/cuberite/blob/master/src/Endianness.h#L5
https://github.com/cuberite/cuberite/blob/master/src/Endianness.h#L16

These implementations unconditionally swap the top and bottom 4 bytes, which only makes sense on little endian platforms. Adding an #ifdef __BIG_ENDIAN__ and then just passing the parameter through in that block will fix it. MSVC doesn't support that, but I don't think there are any big endian platfoms that MSVC compiles to so that doesn't really matter.

from cuberite.

The big question is: Why are you reimplementing a standard library call?

ntohll and friends exist in Win32's winsock.h, while on POSIX systems (really "linux and friends") you want the calls out of <endian.h>: htobe64 and be32toh.

Furthermore: C++20 now introduces std::endian (docs) which would be a good option (constexpr values are evaluated by the compiler and linker, making this a zero-cost runtime choice).

from cuberite.