Comments (4)
I will try to look into the current version of ctapipe and see if this has been corrected and if not, maybe we should post an issue there, as this isn't something we can directly control. The pixel positions are written here:
They're extracted straight from the event's instrument container without any modification (besides padding). We can manually try to correct it within image-extractor but this seems like it isn't the right way to handle it.
from dl1-data-handler.
I'm currently reading the pixel positions from the fits file from https://github.com/cta-observatory/ctapipe-extra, which are identical to the ones in the h5 files. The camera is filled row by row from bottom left to the top right:
Why it seems that the ASTRI camera should be filled from top left to bottom right by 8x8 sub-module sectors? I searched for a gamma shower that triggered ASTRI, CHEC and DigiCam at the same location. So I plotted the same event at the same location with different SST's and the shower orientation is the same. Due to the larger FoV of ASTRI, the shower of ASTRI is closer to the center of the camera than CHEC and DigiCam.
from dl1-data-handler.
I think you are confusing the real (physical) Astri camera, and the simulated one. What comes out in these files is read from the Monte-Carlo simulations, which have in general different pixel ordering for all cameras. Since the ordering doesn't matter except for calibration, this should be fine for most studies.
If we load real data, of course we would need to load the true pixel positions , which would have the physical ordering and are hopefully stored in any raw data file in the proper order. I'm not sure if there is any control over the ordering in the Monte-Carlo, but perhaps it's possible in the configuration to have them come out similar to the real data? That would be part of the MC validation, I guess. Nevertheless, if you change the ordering, you would have to re-produce all monte-carlo files, so if it's critical, it could be considered for prod4+
from dl1-data-handler.
As far as I can tell this will not require any specific action for the foreseeable future, so I'll close it. We can reopen a similar issue when the question of using real data becomes more defined.
from dl1-data-handler.
Related Issues (20)
- Issues with reading HDF5 files HOT 1
- Reduce RAM usage for reading ctapipe-stage1 files HOT 5
- Allowing multiple-workers read with pytorch HOT 9
- Migrate to CTA DL1 data model v2.1.0 HOT 1
- Upgrade to ctapipe v0.14.0
- DL1DataReader doesn't support multiprocessing data loading HOT 2
- Mapped images turned into double
- Add data quality tests
- dl1_data_handler_demo.ipynb: "ValueError: ndarray is not C-contiguous" HOT 8
- Investigating gain selection issue HOT 1
- Update to ctapipe v0.7.0 HOT 7
- Wrong mapping for FlashCam
- No module named dl1_data_handler.writer HOT 2
- traitlets.traitlets.TraitError: Traitlet does not exist: r1_product HOT 13
- Number of loaded images differs for DL1Reader in 'mono' and 'stereo' mode HOT 5
- 'channels' argument in the image_mapper has no functionality HOT 1
- ImageMapper: nearest interpolation normalization HOT 4
- Switch to use ctapipe-stage1? HOT 10
- MAGIC software school
- read the parameter tables in the DL1DH reader HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dl1-data-handler.